From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: [calendar] Holidays menu doesn't go away Date: Sat, 22 Mar 2003 16:39:09 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200303222139.h2MLd95v032311@rum.cs.yale.edu> References: <8765qf178q.fsf@indigo.shootybangbang.com> <871y12epd5.fsf@indigo.shootybangbang.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1048369466 19484 80.91.224.249 (22 Mar 2003 21:44:26 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 22 Mar 2003 21:44:26 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Mar 22 22:44:22 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18wqms-00053o-00 for ; Sat, 22 Mar 2003 22:44:22 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18wqpH-0001SF-00 for ; Sat, 22 Mar 2003 22:46:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18wqm6-00054g-05 for emacs-devel@quimby.gnus.org; Sat, 22 Mar 2003 16:43:34 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18wqim-0003zt-00 for emacs-devel@gnu.org; Sat, 22 Mar 2003 16:40:08 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18wqiG-0003dv-00 for emacs-devel@gnu.org; Sat, 22 Mar 2003 16:39:36 -0500 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.10.13) id 18wqhq-0003RA-00; Sat, 22 Mar 2003 16:39:11 -0500 Original-Received: from rum.cs.yale.edu (localhost [127.0.0.1]) by rum.cs.yale.edu (8.12.8/8.12.8) with ESMTP id h2MLdAPe032313; Sat, 22 Mar 2003 16:39:10 -0500 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.12.8/8.12.8/Submit) id h2MLd95v032311; Sat, 22 Mar 2003 16:39:09 -0500 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: John Paul Wallington Original-cc: Jesper Harder Original-cc: emacs-pretest-bug@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12526 gmane.emacs.pretest.bugs:113 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12526 > >> The "Holidays" menu doesn't go away after quitting from the calendar. > > There is a similar symptom if you invoke then quit `info'. > > Getting rid of the (push 'menu-bar path) avoids those problems, but > causes `recentf-mode' not to add its menu. This reversion avoids > that too. But I don't why the change was made. > > diff -u -r1.57 easymenu.el > --- easymenu.el 16 Mar 2003 00:39:23 -0000 1.57 > +++ easymenu.el 20 Mar 2003 02:24:01 -0000 > @@ -516,9 +516,6 @@ > ITEM is either defined as in `easy-menu-define' or a non-nil value returned > by `easy-menu-item-present-p' or `easy-menu-remove-item' or a menu defined > earlier by `easy-menu-define' or `easy-menu-create-menu'." > - (unless map > - (setq map (current-global-map)) > - (push 'menu-bar path)) The logentry explains why: * emacs-lisp/easymenu.el (easy-menu-name-match): Catch any error that member-ignore-case might signal. (easy-menu-add-item): Default to the global map, as documented. (easy-menu-convert-item-1): Use match-string. As for where it's documented: in the docstring a few lines above. So recentf should probably not use a nil MAP if it wants to use the local map. Or should we change the doc instead ? Stefan