all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Stefan Monnier" <monnier+gnu/emacs/pretest@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [calendar] Holidays menu doesn't go away
Date: Sat, 22 Mar 2003 16:39:09 -0500	[thread overview]
Message-ID: <200303222139.h2MLd95v032311@rum.cs.yale.edu> (raw)
In-Reply-To: 871y12epd5.fsf@indigo.shootybangbang.com

> >> The "Holidays" menu doesn't go away after quitting from the calendar.
> > There is a similar symptom if you invoke then quit `info'.
> 
> Getting rid of the (push 'menu-bar path) avoids those problems, but
> causes `recentf-mode' not to add its menu.  This reversion avoids
> that too.  But I don't why the change was made.
> 
> diff -u -r1.57 easymenu.el
> --- easymenu.el	16 Mar 2003 00:39:23 -0000	1.57
> +++ easymenu.el	20 Mar 2003 02:24:01 -0000
> @@ -516,9 +516,6 @@
>  ITEM is either defined as in `easy-menu-define' or a non-nil value returned
>  by `easy-menu-item-present-p' or `easy-menu-remove-item' or a menu defined
>  earlier by `easy-menu-define' or `easy-menu-create-menu'."
> -  (unless map
> -    (setq map (current-global-map))
> -    (push 'menu-bar path))

The logentry explains why:

	* emacs-lisp/easymenu.el (easy-menu-name-match): Catch any error
	that member-ignore-case might signal.
	(easy-menu-add-item): Default to the global map, as documented.
	(easy-menu-convert-item-1): Use match-string.

As for where it's documented: in the docstring a few lines above.
So recentf should probably not use a nil MAP if it wants to use
the local map.
Or should we change the doc instead ?


	Stefan

  reply	other threads:[~2003-03-22 21:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m3adfri8kz.fsf@defun.localdomain>
2003-03-19 19:33 ` [calendar] Holidays menu doesn't go away John Paul Wallington
2003-03-20  2:36   ` John Paul Wallington
2003-03-22 21:39     ` Stefan Monnier [this message]
2003-03-22 22:14       ` John Paul Wallington
2003-03-22 22:30         ` Stefan Monnier
2003-03-24  2:05           ` Richard Stallman
2003-03-24 15:10             ` Stefan Monnier
2003-03-25  0:52               ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200303222139.h2MLd95v032311@rum.cs.yale.edu \
    --to=monnier+gnu/emacs/pretest@rum.cs.yale.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.