all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Luc Teirlinck <teirllm@dms.auburn.edu>
Cc: emacs-devel@gnu.org
Subject: Re: customize-style, alternative patch.
Date: Thu, 20 Mar 2003 11:32:48 -0600 (CST)	[thread overview]
Message-ID: <200303201732.LAA22043@eel.dms.auburn.edu> (raw)
In-Reply-To: <200303201556.JAA21910@eel.dms.auburn.edu> (message from Luc Teirlinck on Thu, 20 Mar 2003 09:56:29 -0600 (CST))

In the diff I sent before I added the line:

+   (set (make-local-variable 'custom-local-buffer) nil)

to cus-edit.el.

I am not sure if it would not be better to just add:

(make-local-variable 'custom-local-buffer)

instead (and relying on the defcustom to set it to nil).

I do not fully understand the purpose of custom-local-buffer, but not
resetting the value if custom-mode is ran again might be more
consistent with custom-local-buffer being a permanent local.  If so,
below is an alternate patch (which also avoids adding the line in the
middle of the face-customizations):

Change log:

2003-03-20  Luc Teirlinck  <teirllm@mail.auburn.edu>

        * cus-edit.el (custom-mode): Make custom-local-buffer local.

Patch:

===File ~/cus-edit-newdiff==================================
cd /usr/local/share/emacs/21.3.50/lisp/
diff -c /usr/local/share/emacs/21.3.50/lisp/cus-edit.old.el /usr/local/share/emacs/21.3.50/lisp/cus-edit.el
*** /usr/local/share/emacs/21.3.50/lisp/cus-edit.old.el	Fri Mar 14 15:09:47 2003
--- /usr/local/share/emacs/21.3.50/lisp/cus-edit.el	Thu Mar 20 11:07:35 2003
***************
*** 4058,4063 ****
--- 4058,4064 ----
    (use-local-map custom-mode-map)
    (easy-menu-add Custom-mode-menu)
    (make-local-variable 'custom-options)
+   (make-local-variable 'custom-local-buffer)
    (make-local-variable 'widget-documentation-face)
    (setq widget-documentation-face 'custom-documentation-face)
    (make-local-variable 'widget-button-face)

Diff finished at Thu Mar 20 11:14:29
============================================================

  reply	other threads:[~2003-03-20 17:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-17 14:22 customize-style Stephan Stahl
2003-03-17 15:43 ` customize-style Stefan Monnier
2003-03-17 23:25   ` customize-style Richard Stallman
2003-03-18  0:09     ` customize-style Alex Schroeder
2003-03-19  8:49       ` customize-style Richard Stallman
2003-03-19 20:30         ` customize-style Alex Schroeder
2003-03-21  8:10           ` customize-style Stephan Stahl
2003-03-21 19:06           ` customize-style Richard Stallman
2003-03-22 21:43         ` customize-style John Paul Wallington
2003-03-24  2:04           ` customize-style Richard Stallman
2003-03-17 23:28   ` customize-style Alex Schroeder
2003-03-17 21:16 ` customize-style David Masterson
2003-03-17 23:24 ` customize-style Richard Stallman
2003-03-18 13:08   ` customize-style Per Abrahamsen
2003-03-19  0:05     ` customize-style Luc Teirlinck
2003-03-20  8:45       ` customize-style Richard Stallman
2003-03-20 10:44         ` customize-style Per Abrahamsen
2003-03-20 18:39           ` customize-style Luc Teirlinck
2003-03-21  8:49             ` customize-style Per Abrahamsen
2003-03-23  2:53               ` customize-style Richard Stallman
2003-03-20 15:56         ` customize-style Luc Teirlinck
2003-03-20 17:32           ` Luc Teirlinck [this message]
2003-03-23  2:52             ` customize-style, alternative patch Richard Stallman
2003-03-23  3:45               ` Luc Teirlinck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200303201732.LAA22043@eel.dms.auburn.edu \
    --to=teirllm@dms.auburn.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.