all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Janitorial issues: Man-getpage-in-background
Date: Mon, 10 Mar 2003 12:40:36 -0500	[thread overview]
Message-ID: <200303101740.h2AHeavF027280@rum.cs.yale.edu> (raw)
In-Reply-To: 84of4qdqxt.fsf@lucy.is.informatik.uni-duisburg.de

> The function Man-getpage-in-background uses two different ways to set
> environment variables:
> 
> (a) (let ((process-environment (copy-sequence process-environment)))
>       (setenv "FOO" "bar")
>       ...)
> 
> (b) (let ((process-environment (cons "FOO=bar" process-environment)))
>       ...)
> 
> It looks really strange to see them both in the same function...
> 
> Okay to unify?  (I'd choose (a) unless there are objections.)

I'd choose (b) to avoid unnecessary consing (via copying).


	Stefan

      parent reply	other threads:[~2003-03-10 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-05 10:54 Janitorial issues: Man-getpage-in-background Kai Großjohann
2003-03-06 19:29 ` Richard Stallman
2003-03-06 19:57 ` Kevin Rodgers
2003-03-07 17:53   ` Kai Großjohann
2003-03-08 23:03     ` Richard Stallman
2003-03-09 13:46       ` Kai Großjohann
2003-03-11 18:25     ` Stefan Monnier
2003-03-12 11:57       ` Kai Großjohann
2003-03-10 17:40 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200303101740.h2AHeavF027280@rum.cs.yale.edu \
    --to=monnier+gnu/emacs@rum.cs.yale.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.