From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: regression: filling comments in C++ code (today's CVS) Date: Mon, 24 Feb 2003 09:26:37 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200302241426.h1OEQbo27658@rum.cs.yale.edu> References: <5b65sl53l3.fsf@lister.roxen.com><5by95b1d0m.fsf@lister.roxen.com> <5bel6iqlxw.fsf@lister.roxen.com><5by94630ou.fsf@lister.roxen.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1046096873 19156 80.91.224.249 (24 Feb 2003 14:27:53 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 24 Feb 2003 14:27:53 +0000 (UTC) Cc: Stefan Monnier Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18nJaA-0004yX-00 for ; Mon, 24 Feb 2003 15:27:50 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18nJpf-0005bK-00 for ; Mon, 24 Feb 2003 15:43:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18nJZw-0005ha-07 for emacs-devel@quimby.gnus.org; Mon, 24 Feb 2003 09:27:36 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18nJZe-0005cs-00 for emacs-devel@gnu.org; Mon, 24 Feb 2003 09:27:18 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18nJZd-0005cL-00 for emacs-devel@gnu.org; Mon, 24 Feb 2003 09:27:17 -0500 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18nJZ1-0005HO-00; Mon, 24 Feb 2003 09:26:39 -0500 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id h1OEQbo27658; Mon, 24 Feb 2003 09:26:37 -0500 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: Martin Stjernholm Original-cc: Robert Anderson Original-cc: emacs-devel@gnu.org Original-cc: bug-cc-mode@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:11911 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11911 > > > And for some reason it skips empty lines at the beginning of the > > > region, something that should be up to the caller to do. It might > > > contain other similar oddities too. > > > > I'm not sure what you mean by "skips empty lines". > > I mean the following near the start of fill-region-as-paragraph: > > ;; Ignore blank lines at beginning of region. > (skip-chars-forward " \t\n") > > To me it seems more natural if this function compacted all whitespace > the same way, even that at the start. Since the function should basically never be called on any empty line at all, I have no idea why blank lines are skipped like that and neither do I know when it would harm. Could you describe in which context you bumped into it ? > Btw, if it skips \n then it should perhaps skip \r too so that it > works with selective-display. I consider selective-display as an obsolete feature, so I don't think we should try to improve support for it. Stefan