RMAIL, summary/message focus switching with `h' button

RMAIL, summary/message focus switching with `h' button

[Alexander Pohoyda]

Hi,

As a user of Gnus, I'm used to switch the focus (switch-to-buffer)
typing `h'. This is fixed with the following patch.


--- rmailsum.el.orig    Sun Jan  5 23:01:28 2003
+++ rmailsum.el Sun Jan  5 23:40:13 2003
@@ -66,7 +66,13 @@
 (defun rmail-summary ()
   "Display a summary of all messages, one line per message."
   (interactive)
-  (rmail-new-summary "All" '(rmail-summary) nil))
+  (let (was-in-summary)
+    (if (eq major-mode 'rmail-summary-mode)
+       (setq was-in-summary t))
+    (rmail-new-summary "All" '(rmail-summary) nil)
+    ;; Swap the focus.
+    (if was-in-summary
+       (other-window 1))))
 
 ;;;###autoload
 (defun rmail-summary-by-labels (labels)


-- 
Alexander Pohoyda
<alexander.pohoyda@gmx.net>

Re: RMAIL, summary/message focus switching with `h' button

[Thien-Thi Nguyen]

Alexander Pohoyda <alexander.pohoyda@gmx.net> writes:

   +  (let (was-in-summary)
   +    (if (eq major-mode 'rmail-summary-mode)
   +       (setq was-in-summary t))
   +    (rmail-new-summary "All" '(rmail-summary) nil)
   +    ;; Swap the focus.
   +    (if was-in-summary
   +       (other-window 1))))

a minor style nit, that does not address the suitability of the patch:

you can tighten the binding construct to something like:

   (let ((was-in-summary (eq major-mode 'rmail-summary-mode)))
      ...)

this is because `eq' is a predicate and `was-in-summary' is used as a
predicate var.  also, in the combined form `setq' is unnecessary.

thi

Re: RMAIL, summary/message focus switching with `h' button

[Alexander Pohoyda]

> you can tighten the binding construct to something like:
> 
>    (let ((was-in-summary (eq major-mode 'rmail-summary-mode)))
>       ...)

Indeed. Thanks a lot! Here comes a new version:

--- rmailsum.el.orig    Sun Jan  5 23:01:28 2003
+++ rmailsum.el Sun Jan  5 23:40:13 2003
@@ -66,7 +66,10 @@
 (defun rmail-summary ()
   "Display a summary of all messages, one line per message."
   (interactive)
-  (rmail-new-summary "All" '(rmail-summary) nil))
+  (let ((was-in-summary) (eq major-mode 'rmail-summary-mode))
+    (rmail-new-summary "All" '(rmail-summary) nil)
+    ;; Swap the focus.
+    (if was-in-summary (other-window 1))))
 
 ;;;###autoload
 (defun rmail-summary-by-labels (labels)
---

-- 
Alexander Pohoyda
<alexander.pohoyda@gmx.net>

Re: RMAIL, summary/message focus switching with `h' button

[Andreas Schwab]

Alexander Pohoyda <alexander.pohoyda@gmx.net> writes:

|> > you can tighten the binding construct to something like:
|> > 
|> >    (let ((was-in-summary (eq major-mode 'rmail-summary-mode)))
|> >       ...)
|> 
|> Indeed. Thanks a lot! Here comes a new version:
|> 
|> --- rmailsum.el.orig    Sun Jan  5 23:01:28 2003
|> +++ rmailsum.el Sun Jan  5 23:40:13 2003
|> @@ -66,7 +66,10 @@
|>  (defun rmail-summary ()
|>    "Display a summary of all messages, one line per message."
|>    (interactive)
|> -  (rmail-new-summary "All" '(rmail-summary) nil))
|> +  (let ((was-in-summary) (eq major-mode 'rmail-summary-mode))
                           ^

This paren is misplaced, see above.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: RMAIL, summary/message focus switching with `h' button

[Alexander Pohoyda]

> |> +  (let ((was-in-summary) (eq major-mode 'rmail-summary-mode))
>                            ^
> This paren is misplaced, see above.

Right. My bad. Thanks. Corrected patch:

--- rmailsum.el.orig    Sun Jan  5 23:01:28 2003
+++ rmailsum.el Sun Jan  5 23:40:13 2003
@@ -66,7 +66,10 @@
 (defun rmail-summary ()
   "Display a summary of all messages, one line per message."
   (interactive)
-  (rmail-new-summary "All" '(rmail-summary) nil))
+  (let ((was-in-summary (eq major-mode 'rmail-summary-mode))
+    (rmail-new-summary "All" '(rmail-summary) nil)
+    ;; Swap the focus.
+    (if was-in-summary (other-window 1))))
 
 ;;;###autoload
 (defun rmail-summary-by-labels (labels)

-- 
Alexander Pohoyda
<alexander.pohoyda@gmx.net>

Re: RMAIL, summary/message focus switching with `h' button

[Andreas Schwab]

Alexander Pohoyda <alexander.pohoyda@gmx.net> writes:

|> > |> +  (let ((was-in-summary) (eq major-mode 'rmail-summary-mode))
|> >                            ^
|> > This paren is misplaced, see above.
|> 
|> Right. My bad. Thanks. Corrected patch:
|> 
|> --- rmailsum.el.orig    Sun Jan  5 23:01:28 2003
|> +++ rmailsum.el Sun Jan  5 23:40:13 2003
|> @@ -66,7 +66,10 @@
|>  (defun rmail-summary ()
|>    "Display a summary of all messages, one line per message."
|>    (interactive)
|> -  (rmail-new-summary "All" '(rmail-summary) nil))
|> +  (let ((was-in-summary (eq major-mode 'rmail-summary-mode))
|> +    (rmail-new-summary "All" '(rmail-summary) nil)
|> +    ;; Swap the focus.
|> +    (if was-in-summary (other-window 1))))
|>  
|>  ;;;###autoload
|>  (defun rmail-summary-by-labels (labels)

You didn't test your change, did you?  There is a paren missing now.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: RMAIL, summary/message focus switching with `h' button

[Alexander Pohoyda]

Sorry, quite busy at work. This should be OK.

--- rmailsum.el.orig    Sun Jan  5 23:01:28 2003
+++ rmailsum.el Sun Jan  5 23:40:13 2003
@@ -66,7 +66,10 @@
 (defun rmail-summary ()
   "Display a summary of all messages, one line per message."
   (interactive)
-  (rmail-new-summary "All" '(rmail-summary) nil))
+  (let ((was-in-summary (eq major-mode 'rmail-summary-mode)))
+    (rmail-new-summary "All" '(rmail-summary) nil)
+    ;; Swap the focus.
+    (if was-in-summary (other-window 1))))
 
 ;;;###autoload
 (defun rmail-summary-by-labels (labels)


-- 
Alexander Pohoyda
<alexander.pohoyda@gmx.net>