From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: C-h k, C-h f and keyboard macros: Patch.
Date: Tue, 11 Feb 2003 11:19:03 -0500 [thread overview]
Message-ID: <200302111619.h1BGJ3p27311@rum.cs.yale.edu> (raw)
In-Reply-To: 5xisvqvrac.fsf@kfs2.cua.dk
> The call `(remap-command COMMAND)' is equivalent to
> the call `(key-binding [remap COMMAND] nil t)', so in your case,
> you are trying to run (key-binding [remap [home]] nil t)
> which correctly reports a "Key sequence contains invalid event"
> error (but only when there are any remap entries in one of the
> active keymaps -- as there are when you enable cua-mode).
I think it shouldn't report an error but just return nil.
Checking that events are "meaningful" might be OK for define-key but
doesn't make any sense for lookup-key and friends.
If you look at the test used currently, it is already more lax in
lookup-key than in define-key (justified by the following comment:)
/* Allow string since binding for `menu-bar-select-buffer'
includes the buffer name in the key sequence. */
I suggest we just get rid of the checks in lookup-key.
Stefan
next prev parent reply other threads:[~2003-02-11 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-10 23:56 C-h k, C-h f and keyboard macros: Patch Luc Teirlinck
2003-02-11 13:10 ` Kim F. Storm
2003-02-11 12:52 ` Juanma Barranquero
2003-02-11 14:13 ` Kim F. Storm
2003-02-11 14:07 ` Juanma Barranquero
2003-02-11 15:18 ` Kim F. Storm
2003-02-11 14:27 ` Juanma Barranquero
2003-02-11 15:36 ` Kim F. Storm
2003-02-11 14:47 ` Juanma Barranquero
2003-02-11 16:19 ` Stefan Monnier [this message]
2003-02-11 20:58 ` Kim F. Storm
2003-02-12 20:34 ` Richard Stallman
2003-02-13 0:16 ` Kim F. Storm
2003-02-11 16:03 ` Luc Teirlinck
2003-02-12 7:19 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302111619.h1BGJ3p27311@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.