From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: Stefan Monnier <monnier+gnu/emacs@rum.cs.yale.edu>
Subject: Re: [andrew.maguire@ps.ge.com: RE: menu entries missing display of equivalent keyboard sequence]
Date: Thu, 30 Jan 2003 10:21:28 -0500 [thread overview]
Message-ID: <200301301521.h0UFLSv20198@rum.cs.yale.edu> (raw)
In-Reply-To: E18dza2-0006cS-00@fencepost.gnu.org
> - && !INTEGERP (Faref (this, make_number (0))))
> + && SYMBOLP (tem = Faref (this, make_number (0)))
> + && !NILP (Fmemq (XCAR (parse_modifiers (tem)), Vmenu_events)))
>
> parse_modifiers is extremely expensive--it allocates space in caches.
> Doing this for a lot of event types unnecessarily is a bad idea.
My quick experiment indicates that the number of symbols whose cache
is filled is increased by a bit more than 10% (from 618 to 689
in my test case, which was rather conservative).
The experiment was to start Emacs, open an elisp buffer, a TeX buffer,
a PCL-CVS buffer and a *vc-diff* buffer, open up a menu in each one of
them (to cause the `where-is' thingy to happen) and then count the
number of symbols that have the event-symbol-element-mask property set.
> How many different non-integer prefix keys does parse_modifiers get
> called for here? Maybe it is few enough that this is not a real
> issue, but could you check?
I don't know if 70 is few enough.
Stefan
next prev parent reply other threads:[~2003-01-30 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E18QEHY-00040s-00@fencepost.gnu.org>
2003-01-16 0:13 ` [andrew.maguire@ps.ge.com: RE: menu entries missing display of equivalent keyboard sequence] Stefan Monnier
2003-01-18 0:45 ` Richard Stallman
2003-01-28 22:50 ` Stefan Monnier
2003-01-29 21:17 ` Richard Stallman
2003-01-30 15:21 ` Stefan Monnier [this message]
2003-01-31 19:20 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200301301521.h0UFLSv20198@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.