From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.cc-mode.general,gmane.emacs.devel Subject: Re: regression: filling comments in C++ code (today's CVS) Date: Fri, 17 Jan 2003 12:19:24 -0500 Sender: cc-mode-help-admin@lists.sourceforge.net Message-ID: <200301171719.h0HHJOP18943@rum.cs.yale.edu> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1042823966 23971 80.91.224.249 (17 Jan 2003 17:19:26 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 17 Jan 2003 17:19:26 +0000 (UTC) Cc: emacs-devel@gnu.org, bug-cc-mode@gnu.org Return-path: Original-Received: from lists.sourceforge.net ([66.35.250.206] helo=sc8-sf-list2.sourceforge.net) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18Za9L-0006ED-00 for ; Fri, 17 Jan 2003 18:19:23 +0100 Original-Received: from sc8-sf-list1-b.sourceforge.net ([10.3.1.13] helo=sc8-sf-list1.sourceforge.net) by sc8-sf-list2.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 18ZaA2-0004dd-00; Fri, 17 Jan 2003 09:20:06 -0800 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by sc8-sf-list1.sourceforge.net with esmtp (Cipher TLSv1:DES-CBC3-SHA:168) (Exim 3.31-VA-mm2 #1 (Debian)) id 18Za9f-0007Rz-00 for ; Fri, 17 Jan 2003 09:19:44 -0800 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.10) id 18Za9d-0000SP-00 for bug-cc-mode@gnu.org; Fri, 17 Jan 2003 12:19:41 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18Za9T-00062f-00 for bug-cc-mode@gnu.org; Fri, 17 Jan 2003 12:19:31 -0500 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18Za9R-00061h-00; Fri, 17 Jan 2003 12:19:29 -0500 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.11.6/8.11.6) id h0HHJOP18943; Fri, 17 Jan 2003 12:19:24 -0500 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: "Robert Anderson" Errors-To: cc-mode-help-admin@lists.sourceforge.net X-BeenThere: cc-mode-help@lists.sourceforge.net X-Mailman-Version: 2.0.9-sf.net Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Bug reports, feature requests, and general talk about CC Mode. List-Unsubscribe: , List-Archive: X-Original-Date: Fri, 17 Jan 2003 12:19:24 -0500 Xref: main.gmane.org gmane.emacs.cc-mode.general:319 gmane.emacs.devel:10811 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10811 > >> I just updated from CVS today and it appears there has been a > >> rather serious regression with respect to filling comments in C++ > >> code. > >> > >> Here's a test case, in cc-mode: > >> > >> main() > >> { > >> // a[M-q] > >> > >> comes back with: > >> > >> fill-comment-paragraph: Search failed: "/\\*+ *\\|//+ *" > > > >Could you provide the full backtrace (by setting > >Options => Enter Debugger on Error) ? > > I guess a _15 character_ test case is too much work to cut/paste? :) The difference is between "a few seconds for each bug reporter" and "a few seconds * N bug reports for each maintainer". We don't have too much maintainer-time in our hands. > Here 'tis: > > Debugger entered--Lisp error: (search-failed "/\\*+ *\\|//+ *") > re-search-forward("/\\*+ *\\|//+ *") > fill-comment-paragraph(nil) > fill-paragraph(nil) > apply(fill-paragraph nil) > c-mask-comment(t nil fill-paragraph nil) > c-fill-paragraph(nil) > call-interactively(c-fill-paragraph) Why on earth does cc-mode rebind M-q instead of setting fill-paragraph-function ? Anyway, it's obviously a problem in my new filling code. I'll take a look at it, but in the mean time, rebinding M-q to fill-paragraph (in c-common-mode-hook I guess) and setting fill-paragraph-function to `c-fill-paragraph' should hide the problem. Stefan ------------------------------------------------------- This SF.NET email is sponsored by: Thawte.com - A 128-bit supercerts will allow you to extend the highest allowed 128 bit encryption to all your clients even if they use browsers that are limited to 40 bit encryption. Get a guide here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en