all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Misc. minor compile.el issues
@ 2002-12-06  0:34 Kim F. Storm
  2002-12-06 16:55 ` Stefan Monnier
  2002-12-07 21:26 ` Richard Stallman
  0 siblings, 2 replies; 10+ messages in thread
From: Kim F. Storm @ 2002-12-06  0:34 UTC (permalink / raw)



The doc string for compilation-process-setup-function starts with a
`*' identifying it as a user option.  Does that really make sense?

IMO, it is similar to compilation-buffer-name-function which is
not a user option.


Related to this, I would like the setup function to be able to
access the buffer and/or window for the compilation process (e.g.
to set buffer-local variables).

Currently, this can be achieved by accessing the dynamic bound
variables `outbuf' and `outwin' from the setup function, but that
seems like a gross hack.  

It would make more sense to provide `outwin' as argument to the setup
function, but that would break existing code.

Alternatively, we could dynamically bind `compilation-window' and
`compilation-buffer' around the call to the setup function (and
document this "interface" in the compilation-process-setup-function
doc string).

This is still a hack, but using well-defined names.


As a final issue, I think that although the documentation for
compilation-process-setup-function says it is run just before the
process is started, it makes more sense to swap the following two
forms, to allow the setup function to control the
compilation-window-height:

	(compilation-set-window-height outwin)
	(if compilation-process-setup-function
	    (funcall compilation-process-setup-function))

In any case, I don't see any ill effects of swapping them.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2002-12-10  0:51 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-06  0:34 Misc. minor compile.el issues Kim F. Storm
2002-12-06 16:55 ` Stefan Monnier
2002-12-06 20:15   ` Kim F. Storm
2002-12-06 20:14     ` Stefan Monnier
2002-12-07  1:49       ` Kim F. Storm
2002-12-09 15:31         ` Stefan Monnier
2002-12-07 21:26 ` Richard Stallman
2002-12-08  1:38   ` Kim F. Storm
2002-12-09 20:21     ` Richard Stallman
2002-12-10  0:51       ` Kim F. Storm

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.