From: Juanma Barranquero <lektu@terra.es>
Cc: Eli Zaretskii <eliz@is.elta.co.il>,
jasonr@btinternet.com, andrewi@gnu.org, jay_finger@hotmail.com,
emacs-devel@gnu.org
Subject: Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows]
Date: Thu, 24 Oct 2002 10:40:04 +0200 [thread overview]
Message-ID: <20021024103730.AB6A.LEKTU@terra.es> (raw)
In-Reply-To: <5xof9kp4c4.fsf@kfs2.cua.dk>
On 24 Oct 2002 11:35:07 +0200, storm@cua.dk (Kim F. Storm) wrote:
> dispextern.h seems like a good choice. It actually uses XColor in a prototype...
> I suggest adding the following near the top of the file:
>
> #ifdef HAVE_X_WINDOWS
> #include <X11/Xlib.h>
> #ifdef USE_X_TOOLKIT
> #include <X11/Intrinsic.h>
> #endif /* USE_X_TOOLKIT */
> + #else /* !HAVE_X_WINDOWS */
> +
> + /* X-related stuff used by non-X gui code. */
> +
> + typedef struct {
> + unsigned long pixel;
> + unsigned short red, green, blue;
> + char flags;
> + char pad;
> + } XColor;
> +
> #endif /* HAVE_X_WINDOWS */
OK.
> Avoiding [verbatim] duplication of code or defs always make me feel better :-)
Yeah :)
OK, so I'll wait for a while and if no one objects I'll rework
yesterday's patch to use your suggested fix.
Should it also be done on EMACS_21_1_RC?
/L/e/k/t/u
next prev parent reply other threads:[~2002-10-24 8:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-23 13:37 [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows] jasonr
2002-10-23 13:43 ` Juanma Barranquero
2002-10-23 16:41 ` Eli Zaretskii
2002-10-24 6:42 ` Juanma Barranquero
2002-10-24 7:13 ` Eli Zaretskii
2002-10-24 8:06 ` Juanma Barranquero
2002-10-24 9:35 ` Kim F. Storm
2002-10-24 8:40 ` Juanma Barranquero [this message]
2002-10-24 17:28 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2002-10-24 8:25 jasonr
2002-10-23 13:44 jasonr
2002-10-23 7:10 Richard Stallman
2002-10-23 12:06 ` Juanma Barranquero
2002-10-23 16:19 ` Andrew Choi
2002-10-23 16:47 ` Juanma Barranquero
2002-10-23 16:43 ` Eli Zaretskii
2002-10-24 6:47 ` Juanma Barranquero
2002-10-25 7:51 ` Juanma Barranquero
2002-10-23 12:13 ` Juanma Barranquero
2002-10-28 5:57 ` Harald.Maier.BW
2002-10-28 17:52 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021024103730.AB6A.LEKTU@terra.es \
--to=lektu@terra.es \
--cc=andrewi@gnu.org \
--cc=eliz@is.elta.co.il \
--cc=emacs-devel@gnu.org \
--cc=jasonr@btinternet.com \
--cc=jay_finger@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.