Patch for Windows implementation of play-sound

Patch for Windows implementation of play-sound

[Ben Key]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

The attached zip file contains a patch I have been working on that adds a
Windows compatible implementation of play-sound to GNU Emacs.  I have tested
this patch with version 21.2 and 21.3.50 (CVS).  I have also tested this
patch with Microsoft Visual C++ 6.0 and MinGW 2.0 / MSys 1.08.

The ReadMe.txt file contained within the zip file gives a brief explanation
of how to install the patch.

I have requested that this change be assigned to me so that it can be
incorporated into Emacs.  But, until that happens, anyone who wishes to may
use this patch.

Feel free to contact me a <Bkey1@tampabay.rr.com> if you have any questions
or comments.




[-- Attachment #2: emacs-w32-play-sound-patch.zip --]
[-- Type: application/x-zip-compressed, Size: 13547 bytes --]

Re: Patch for Windows implementation of play-sound

[Juanma Barranquero]

On Wed, 16 Oct 2002 00:04:34 -0400, "Ben Key" <Bkey1@tampabay.rr.com> wrote:

> I have also tested this
> patch with Microsoft Visual C++ 6.0 and MinGW 2.0 / MSys 1.08.

Do you have a recent SDK from msdn.microsoft.com? The -DWINVER=0x0501
gives me about a gazillion of those:

> NOTE: WINVER has been defined as 0x0500 or greater which enables
> Windows NT 5.0 and Windows 98 features. When these headers were released,
> Windows NT 5.0 beta 1 and Windows 98 beta 2.1 were the current versions.
> 
> For this release when WINVER is defined as 0x0500 or greater, you can only
> build beta or test applications.  To build a retail application,
> set WINVER to 0x0400 or visit http://www.microsoft.com/msdn/sdk
> to see if retail Windows NT 5.0 or Windows 98 headers are available.
> 
> See the SDK release notes for more information.


Also, is this bit from src/emacs.c intended, or did you cvs diff and
accidentally got this reversed?

> @@ -2302,13 +2302,11 @@
>                doc: /* Non-nil means Emacs is running without interactive terminal.  */);
> 
>    DEFVAR_LISP ("kill-emacs-hook", &Vkill_emacs_hook,
> -              doc: /* Hook to be run when kill-emacs is called.
> -Since `kill-emacs' may be invoked when the terminal is disconnected (or
> +              doc: /* Hook to be run whenever kill-emacs is called.
> +Since kill-emacs may be invoked when the terminal is disconnected (or
>  in other similar situations), functions placed on this hook should not
>  expect to be able to interact with the user.  To ask for confirmation,
> -see `kill-emacs-query-functions' instead.
> -
> -The hook is not run in batch mode, i.e., if `noninteractive' is non-nil.  */);
> +see `kill-emacs-query-functions' instead.  */);
>    Vkill_emacs_hook = Qnil;
> 
>    empty_string = build_string ("");


                                                           /L/e/k/t/u

RE: Patch for Windows implementation of play-sound

[Ben Key]

I do have the newest MSSDK installed.  Therefore, I am not getting the
warnings you are getting.  However, if I do not define _WIN32_WINNT and
WINVER to be at least 0x0500 I get several compilation errors.

As for the section of emacs.c you mentioned, you a correct that that was an
unintentional change.  Tomorrow I will create a new diff to resolve that
problem.

-----Original Message-----
From: Juanma Barranquero [mailto:lektu@terra.es]
Sent: Wednesday, October 16, 2002 12:34 PM
To: Bkey1@tampabay.rr.com
Cc: gnu-emacs-sources@gnu.org; emacs-devel@gnu.org
Subject: Re: Patch for Windows implementation of play-sound


On Wed, 16 Oct 2002 00:04:34 -0400, "Ben Key" <Bkey1@tampabay.rr.com> wrote:

> I have also tested this
> patch with Microsoft Visual C++ 6.0 and MinGW 2.0 / MSys 1.08.

Do you have a recent SDK from msdn.microsoft.com? The -DWINVER=0x0501
gives me about a gazillion of those:

> NOTE: WINVER has been defined as 0x0500 or greater which enables
> Windows NT 5.0 and Windows 98 features. When these headers were released,
> Windows NT 5.0 beta 1 and Windows 98 beta 2.1 were the current versions.
>
> For this release when WINVER is defined as 0x0500 or greater, you can only
> build beta or test applications.  To build a retail application,
> set WINVER to 0x0400 or visit http://www.microsoft.com/msdn/sdk
> to see if retail Windows NT 5.0 or Windows 98 headers are available.
>
> See the SDK release notes for more information.


Also, is this bit from src/emacs.c intended, or did you cvs diff and
accidentally got this reversed?

> @@ -2302,13 +2302,11 @@
>                doc: /* Non-nil means Emacs is running without interactive
terminal.  */);
>
>    DEFVAR_LISP ("kill-emacs-hook", &Vkill_emacs_hook,
> -              doc: /* Hook to be run when kill-emacs is called.
> -Since `kill-emacs' may be invoked when the terminal is disconnected (or
> +              doc: /* Hook to be run whenever kill-emacs is called.
> +Since kill-emacs may be invoked when the terminal is disconnected (or
>  in other similar situations), functions placed on this hook should not
>  expect to be able to interact with the user.  To ask for confirmation,
> -see `kill-emacs-query-functions' instead.
> -
> -The hook is not run in batch mode, i.e., if `noninteractive' is non-nil.
*/);
> +see `kill-emacs-query-functions' instead.  */);
>    Vkill_emacs_hook = Qnil;
>
>    empty_string = build_string ("");


                                                           /L/e/k/t/u

Re: Patch for Windows implementation of play-sound

[Juanma Barranquero]

On Thu, 17 Oct 2002 23:31:21 -0400, "Ben Key" <Bkey1@tampabay.rr.com> wrote:

> I do have the newest MSSDK installed.  Therefore, I am not getting the
> warnings you are getting.  However, if I do not define _WIN32_WINNT and
> WINVER to be at least 0x0500 I get several compilation errors.

What causes those compilation errors?

> As for the section of emacs.c you mentioned, you a correct that that was an
> unintentional change.  Tomorrow I will create a new diff to resolve that
> problem.

Ok, send it and I'll try to test it.

                                                           /L/e/k/t/u