`delete-frame-hook' isn't defined

`delete-frame-hook' isn't defined

[John Paul Wallington]

etc/NEWS says:

** Function `delete-frame' runs `delete-frame-hook' before actually
deleting the frame.  The hook is called with one arg, the frame
being deleted.


However, `delete-frame-hook' isn't presently defined as a variable.
`delete-frame' does run the hook if you define it.

Should it be defined?  One possible problem is that tooltips are
frames that are deleted when they disappear.  Users may not expect the
hook to be run then.

Also, should it be renamed to `delete-frame-functions' because it is
an abnormal hook ?

-- 
John Paul Wallington

Re: `delete-frame-hook' isn't defined

[Richard Stallman]

    However, `delete-frame-hook' isn't presently defined as a variable.
    `delete-frame' does run the hook if you define it.

    Should it be defined?

Yes, nowadays we may as well give it a defvar.

			   One possible problem is that tooltips are
    frames that are deleted when they disappear.  Users may not expect the
    hook to be run then.

Hmm.  Perhaps it should not be run for tooltip frames.
Can you find a clean way to distinguish tooltip frames?

    Also, should it be renamed to `delete-frame-functions' because it is
    an abnormal hook ?

Yes, definitely.  It was a mistake to give it the name
delete-frame-hook.

Re: `delete-frame-hook' isn't defined

[Stefan Monnier]

> Also, should it be renamed to `delete-frame-functions' because it is
> an abnormal hook ?

I think it should stay as `delete-frame-hook' but should not receive
any argument, instead the frame that's about to be deleted should
just be made the `selected-frame'.
But otherwise, yes please rename it.


	Stefan

Re: `delete-frame-hook' isn't defined

[Stefan Monnier]

> > > Also, should it be renamed to `delete-frame-functions' because it is
> > > an abnormal hook ?
> > 
> > I think it should stay as `delete-frame-hook' but should not receive
> > any argument, instead the frame that's about to be deleted should
> > just be made the `selected-frame'.
> 
> Could you explain why that is preferable ?

Because then it's a "standard hook" and I find it a good thing
to keep things as standard as possible: you don't need to look at the
docstring to know the calling convention, for example.


	Stefan

Re: `delete-frame-hook' isn't defined

[John Paul Wallington]

> 			   One possible problem is that tooltips are
>     frames that are deleted when they disappear.  Users may not expect the
>     hook to be run then.
> 
> Hmm.  Perhaps it should not be run for tooltip frames.
> Can you find a clean way to distinguish tooltip frames?

I haven't found a clean way yet.  If someone knows one, please yell!

One possibility is to run the hook unless the frame's `name' parameter
is `tooltip', but that is probably too fragile as
`tooltip-frame-parameters' is customizable.

-- 
John Paul Wallington

Re: `delete-frame-hook' isn't defined

[John Paul Wallington]

> > Also, should it be renamed to `delete-frame-functions' because it is
> > an abnormal hook ?
> 
> I think it should stay as `delete-frame-hook' but should not receive
> any argument, instead the frame that's about to be deleted should
> just be made the `selected-frame'.

Could you explain why that is preferable ?  

-- 
John Paul Wallington

Re: `delete-frame-hook' isn't defined

[Richard Stallman]

    > Hmm.  Perhaps it should not be run for tooltip frames.
    > Can you find a clean way to distinguish tooltip frames?

    I haven't found a clean way yet.  If someone knows one, please yell!

The code that creates a tooltip frame could give it a frame property
`tooltip' with value t.  Then it would be easy to distinguish them.

Re: `delete-frame-hook' isn't defined

[John Paul Wallington]

>     > Hmm.  Perhaps it should not be run for tooltip frames.
>     > Can you find a clean way to distinguish tooltip frames?
> 
>     I haven't found a clean way yet.  If someone knows one, please yell!
> 
> The code that creates a tooltip frame could give it a frame property
> `tooltip' with value t.  Then it would be easy to distinguish them.

That sounds good.  Is it okay to change `delete-frame-hook' to a
standard hook where the frame to be deleted is made the selected frame?

-- 
John Paul Wallington

Re: `delete-frame-hook' isn't defined

[Richard Stallman]

    That sounds good.  Is it okay to change `delete-frame-hook' to a
    standard hook where the frame to be deleted is made the selected frame?

I think it is cleaner to leave the calling convention unchanged.

Re: `delete-frame-hook' isn't defined

[John Paul Wallington]

>     That sounds good.  Is it okay to change `delete-frame-hook' to a
>     standard hook where the frame to be deleted is made the selected frame?
> 
> I think it is cleaner to leave the calling convention unchanged.

`delete-frame' now runs `delete-frame-functions' instead of
`delete-frame-hook'.  Is it worthwhile making `delete-frame-hook' an
alias for `delete-frame-functions' ?

-- 
John Paul Wallington

Re: `delete-frame-hook' isn't defined

[Juanma Barranquero]

On Wed, 02 Oct 2002 10:59:44 +0100, John Paul Wallington <jpw@shootybangbang.com> wrote:

> `delete-frame' now runs `delete-frame-functions' instead of
> `delete-frame-hook'.  Is it worthwhile making `delete-frame-hook' an
> alias for `delete-frame-functions' ?

If you're renaming `delete-frame-hook' to `delete-frame-functions',
please add an alias (`delete-frame-hook' exists since 21.1) and also:

(make-obsolete-variable 'delete-frame-hook 'delete-frame-functions "21.4")


                                                           /L/e/k/t/u

Re: `delete-frame-hook' isn't defined

[Richard Stallman]

    `delete-frame' now runs `delete-frame-functions' instead of
    `delete-frame-hook'.  Is it worthwhile making `delete-frame-hook' an
    alias for `delete-frame-functions' ?

Yes, we may as well.  Can you also mark it obsolete so people
will change the name?