From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: smtpmail.el fixes for windows
Date: Wed, 11 Sep 2002 14:02:49 -0600 (MDT)
Sender: emacs-devel-admin@gnu.org
Message-ID: <200209112002.g8BK2nj20489@wijiji.santafe.edu>
References: <ilubs75ksk8.fsf@latte.josefsson.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: localhost.gmane.org
X-Trace: main.gmane.org 1031776231 29877 127.0.0.1 (11 Sep 2002 20:30:31 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 11 Sep 2002 20:30:31 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 17pE86-0007lk-00
	for <emacs-devel@main.gmane.org>; Wed, 11 Sep 2002 22:30:30 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 17pEjA-0005sU-00
	for <emacs-devel@quimby.gnus.org>; Wed, 11 Sep 2002 23:08:48 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 17pE8D-0002vp-00; Wed, 11 Sep 2002 16:30:37 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 17pE6E-0002gW-00
	for emacs-devel@gnu.org; Wed, 11 Sep 2002 16:28:34 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 17pE6B-0002fR-00
	for emacs-devel@gnu.org; Wed, 11 Sep 2002 16:28:33 -0400
Original-Received: from gnudist.gnu.org ([199.232.41.7])
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 17pE6B-0002fF-00; Wed, 11 Sep 2002 16:28:31 -0400
Original-Received: from pele.santafe.edu ([192.12.12.119])
	by gnudist.gnu.org with esmtp (Exim 4.10)
	id 17pE6A-0004o4-00; Wed, 11 Sep 2002 16:28:30 -0400
Original-Received: from wijiji.santafe.edu (wijiji [192.12.12.5])
	by pele.santafe.edu (8.11.6+Sun/8.11.6) with ESMTP id g8BK3N513340;
	Wed, 11 Sep 2002 14:03:23 -0600 (MDT)
Original-Received: (from rms@localhost)
	by wijiji.santafe.edu (8.11.6+Sun/8.9.3) id g8BK2nj20489;
	Wed, 11 Sep 2002 14:02:49 -0600 (MDT)
X-Authentication-Warning: wijiji.santafe.edu: rms set sender to rms@wijiji using -f
Original-To: jas@extundo.com
In-reply-to: <ilubs75ksk8.fsf@latte.josefsson.org> (message from Simon
	Josefsson on Wed, 11 Sep 2002 07:23:51 +0200)
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:7851
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7851

It seems ok to me.  However, I think it would be better
to call format-time-string directly, just once for the date
and the time.

That way you can avoid the need to load the time-stamp library,
and make the code a little smaller rather than a little bigger.