find-alternate-file and kill-buffer-query-functions

find-alternate-file and kill-buffer-query-functions

[Noah Friedman]

I've been wondering why it was that sometimes all my shell buffers and
other things I had protected from accidentally killing with a hook on
kill-buffer-query-functions, would sometimes get killed anyway when I
marked everything for deletion in the buffer menu.

It turns out that find-alternate-file is setting
kill-buffer-query-functions to nil; this was a change made 2002-07-14.

This variable is not buffer-local by default.  I think you need to
let-bind it carefully using something like the logic below:

    ...
    (unless (eq (current-buffer) obuf)
      ;; We already asked; don't ask again.
      (save-excursion
        ;; switch to buffer before shadowing query functions, in case
        ;; they are buffer-local
        (set-buffer obuf)
        (let ((kill-buffer-query-functions nil))
          (kill-buffer obuf))))

Re: find-alternate-file and kill-buffer-query-functions

[Stefan Monnier]

>     (unless (eq (current-buffer) obuf)
>       ;; We already asked; don't ask again.
>       (save-excursion
>         ;; switch to buffer before shadowing query functions, in case
>         ;; they are buffer-local
>         (set-buffer obuf)
>         (let ((kill-buffer-query-functions nil))
>           (kill-buffer obuf))))

Sounds right, except that I'd recommend `with-current-buffer'
in place of `save-excursion' + `set-buffer'.


	Stefan

Re: find-alternate-file and kill-buffer-query-functions

[Richard Stallman]

Thanks.