ange-ftp save-buffer bug in 21.2

ange-ftp save-buffer bug in 21.2

[jdhunter]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2002-04-29 on mother.paradise.lost
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: C
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

When I try to save a file via ange-ftp using save-buffer, I get an error 

 byte-code: Keyboard macro terminated by a command ringing the bell

I recently upgraded to 21.2 from 20.7, where I was able to work with
ange-ftp w/o incident.  I loaded emacs with 

/usr/local/bin/emacs-21.2 -q --no-site-file 

Here is the *Backtrace*:

Debugger entered--Lisp error: (error "Keyboard macro terminated by a command ringing the bell")
  beep()
  byte-code("Æ\x18\b„l\0ÇÈÉ	!\"ˆÊ\x1aË )—‰^[\fUƒ\x1e\0Ì‚#\0Í\vÎ\"A‰\x10„6\0Ï ˆÇÐ!ˆÑÒ!ˆ‚h\0\bÌ=ƒD\0Ó ˆÆ\x10‚h\0\bÔ=ƒ[\0ÕÆÖ ?\"ˆ×ØÙ	D\"ˆ‚h\0\bÚ=ƒh\0×ØÛ	D\"ˆ)‚\x02\0ÇÜ!ˆÆ‰\x15)‡" [answer fn cursor-in-echo-area tem help-char buffer-backed-up nil message "%s changed on disk; really edit the buffer? (y, n, r or C-h) " file-name-nondirectory t read-char help assoc ((110 . yield) (7 . yield) (121 . proceed) (114 . revert) (63 . help)) beep "Please type y, n or r; or ? for help" sit-for 3 ask-user-about-supersession-help revert revert-buffer buffer-modified-p signal file-supersession "File reverted" yield "File changed on disk" "File on disk now will become a backup file if you save these changes."] 5)
  ask-user-about-supersession-threat("/jdh2358@mother 8021:/Seizure/add_to_filesystem_py")
  set-buffer-modified-p(t)
  byte-code("\b\x11\n\x13Å\f!‡" [last-coding-system-used coding-system-used filename buffer-file-name mod-p set-buffer-modified-p] 2)
  ange-ftp-write-region(1 1357 "/jdh2358@mother 8021:/Seizure/add_to_filesystem_py" nil t)
  apply(ange-ftp-write-region (1 1357 "/jdh2358@mother 8021:/Seizure/add_to_filesystem_py" nil t))
  ange-ftp-hook-function(write-region 1 1357 "/jdh2358@mother 8021:/Seizure/add_to_filesystem_py" nil t)
  write-region(1 1357 "/jdh2358@mother 8021:/Seizure/add_to_filesystem_py" nil t "/jdh2358@mother 8021:/Seizure/add_to_filesystem_py")
  basic-save-buffer-2()
  basic-save-buffer-1()
  basic-save-buffer()
  save-buffer(1)
  call-interactively(save-buffer)


I have successfully edited files via ange-ftp with 21.2 using a
different ftp server, so it is some combination of the ftp server and
the version of ange-ftp that ships with 21.2.  The server that failed
above was the zope ftp server (which I can use fine with ange-ftp in
emacs 20.7).

Recent input:
SPC d e g <backspace> b <M-tab> <M-tab> - o <M-tab> 
e <M-tab> e <backspace> r <tab> <backspace> <M-tab> 
SPC t ) <help-echo> <help-echo> C-g M-x s e t - v <tab> 
a <tab> <return> d e b u g - o n <M-tab> <tab> <tab> 
e <tab> <return> t <return> C-x C-s <up> <up> C-SPC 
<C-down> <C-down> <C-up> <up> <help-echo> <help-echo> 
M-x s u <tab> <backspace> <backspace> b u <tab> C-g 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <report-emacs-bug>

Recent messages:

(/usr/local/bin/emacs-21.2 -q --no-site-file)
Loading disp-table...done
Loading tool-bar...done
Loading image...done
Loading tooltip...done
For information about the GNU Project and its goals, type C-h C-p.
Loading ange-ftp...done
Password for jdh2358@mother 8021: 
Password for jdh2358@mother 8021: .
Password for jdh2358@mother 8021: ..
Password for jdh2358@mother 8021: ........
Opening FTP connection to mother 8021...done
Logging in as user jdh2358@mother 8021...done
Getting PWD...done
Listing /jdh2358@mother 8021:/...done
Loading dired...done
Reading directory /jdh2358@mother 8021:/Seizure/...
Listing /jdh2358@mother 8021:/Seizure/...done
Reading directory /jdh2358@mother 8021:/Seizure/...done
Retrieving add_to_filesystem_py...done
Making completion list...
Loading view...done
Making completion list...done
Making completion list...done
list: Quit
Making completion list...
Loading etags...done
complete-tag: No tags table loaded; try M-x visit-tags-table
Making completion list...
add_to_filesystem_py changed on disk; really edit the buffer? (y, n, r or C-h) 
Entering debugger...
 [2 times]

Thanks!
John Hunter

Re: ange-ftp save-buffer bug in 21.2

[Richard Stallman]

The problem is evidently because of the following code in
ange-ftp-write-region.

		(let ((executing-kbd-macro t)
		      (filename (buffer-file-name))
		      (mod-p (buffer-modified-p)))
		  (unwind-protect
		      (progn
			(ange-ftp-real-write-region start end temp nil visit)
			(setq coding-system-used last-coding-system-used))

Does anyone see a purpose for binding executing-kbd-macro here?  The
code to bind it has been that way for a long, long time.

Re: ange-ftp save-buffer bug in 21.2

[Michael Sperber [Mr. Preprocessor]]

>>>>> "RMS" == Richard Stallman <rms@gnu.org> writes:

RMS> The problem is evidently because of the following code in
RMS> ange-ftp-write-region.

RMS> 		(let ((executing-kbd-macro t)
RMS> 		      (filename (buffer-file-name))
RMS> 		      (mod-p (buffer-modified-p)))
RMS> 		  (unwind-protect
RMS> 		      (progn
RMS> 			(ange-ftp-real-write-region start end temp nil visit)
RMS> 			(setq coding-system-used last-coding-system-used))

RMS> Does anyone see a purpose for binding executing-kbd-macro here?  The
RMS> code to bind it has been that way for a long, long time.

For what it's worth, here's the analogous section in EFS.  It has a
comment:

			  (let ((executing-macro t))
			    ;; let-bind executing-macro to inhibit messaging.
			    ;; Setting VISIT to 'quiet is more elegant.
			    ;; But in Emacs 18, doing it this way allows
			    ;; us to modify the visited file modtime, so
			    ;; that undo's show the buffer modified.

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla

Re: ange-ftp save-buffer bug in 21.2

[Richard Stallman]

Thanks for finding that.  It now seems that using (or visit 'quiet)
instead of just `visit' as the 5th argument to
ange-ftp-real-write-region is the best solution.