M-x edit-kbd-macro C-h l does not work in X

M-x edit-kbd-macro C-h l does not work in X

[Anant Sahai]

This bug report will be sent to the Free Software
Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers
do not have
translators to read other languages for them.

Your bug report will be posted to the
bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (i386-redhat-linux-gnu, X toolkit,
Xaw3d scroll bars)
 of 2002-04-08 on porky.devel.redhat.com
configured using `configure  i386-redhat-linux
--prefix=/usr --exec-prefix=/usr --bindir=/usr/bin
--sbindir=/usr/sbin --sysconfdir=/etc
--datadir=/usr/share --includedir=/usr/include
--libdir=/usr/lib --libexecdir=/usr/libexec
--localstatedir=/var --sharedstatedir=/usr/com
--mandir=/usr/share/man --infodir=/usr/share/info
--with-gcc --with-pop --with-sound'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


This bug only occurs when I run in X. If I run using
"emacs -nw"
or run in a GNU/Linux virtual terminal, there is no
bug. Also, I 
have noticed that it works fine in xemacs if that
helps at all.

The result is that the wonderful ability to generate a
keyboard 
macro based on what I have already typed interactively
in the past
is effectively gone. 

You can see exactly what triggered the bug below:


Recent input:
<help-echo> H e l l o SPC t h e r e SPC f r u i t SPC 
f a r m e r <return> T h i s SPC i s SPC n u t s
<return> 
M-x e d i <tab> t <tab> k <tab> <return> C-h l
<help-echo> 
<help-echo> <help-echo> M-x b u <tab> <backspace>
<backspace> 
r e <tab> p <tab> o <tab> r <tab> <return>

Recent messages:
Loading /home/sahai/.xemacs/init.el (source)...done
Loading /home/sahai/.xemacs/custom.el (source)...done
For information about the GNU Project and its goals,
type C-h C-p.
Making completion list...
Loading view...done
Loading edmacro...done
Formatting keyboard macro...
edit-kbd-macro: Wrong type argument: listp, #<frame
emacs@localhost.localdomain 0x8458288\ >
Making completion list... [4 times]
Loading emacsbug...done



__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

Re: M-x edit-kbd-macro C-h l does not work in X

[Richard Stallman]

Does this patch fix it?

*** edmacro.el.~1.24.~	Mon Jul 16 18:45:42 2001
--- edmacro.el	Wed Jun 19 12:10:16 2002
***************
*** 609,631 ****
  		 (setq i (1+ i) start (1+ start)))
  	       res))))))
  
! (defun edmacro-fix-menu-commands (macro)
!   (when (vectorp macro)
!     (let ((i 0) ev)
!       (while (< i (length macro))
! 	(when (consp (setq ev (aref macro i)))
! 	  (cond ((equal (cadadr ev) '(menu-bar))
! 		 (setq macro (vconcat (edmacro-subseq macro 0 i)
! 				      (vector 'menu-bar (car ev))
! 				      (edmacro-subseq macro (1+ i))))
! 		 (incf i))
  		;; It would be nice to do pop-up menus, too, but not enough
  		;; info is recorded in macros to make this possible.
  		(t
  		 (error "Macros with mouse clicks are not %s"
  			"supported by this command"))))
! 	(incf i))))
!   macro)
  \f
  ;;; Parsing a human-readable keyboard macro.
  
--- 609,638 ----
  		 (setq i (1+ i) start (1+ start)))
  	       res))))))
  
! (defun edmacro-fix-menu-commands (macro &optional noerror)
!   (if (vectorp macro)
!       (let (result)
! 	;; Make a list of the elements.
! 	(setq macro (append macro nil))
! 	(dolist (ev macro)
! 	  (cond ((atom ev)
! 		 (push ev result))
! 		((eq (car ev) 'help-echo))
! 		((equal ev '(menu-bar))
! 		 (push 'menu-bar result))
! 		((equal (cadadr ev) '(menu-bar))
! 		 (push (vector 'menu-bar (car ev)) result))
  		;; It would be nice to do pop-up menus, too, but not enough
  		;; info is recorded in macros to make this possible.
+ 		(noerror
+ 		 ;; Just ignore mouse events.
+ 		 nil)
  		(t
  		 (error "Macros with mouse clicks are not %s"
  			"supported by this command"))))
! 	;; Reverse them again and make them back into a vector.
! 	(vconcat (nreverse result)))
!     macro))
  \f
  ;;; Parsing a human-readable keyboard macro.