Re: Cannot link movemail on SunOS-5.5 in latest CVS

Re: Cannot link movemail on SunOS-5.5 in latest CVS

[Richard Stallman]

There have not been a lot of changes in movemail lately.
I don't see any changes that would cause this.
It looks like Sun did something that broke it.

It is exceedingly strange that simply renaming the Make variable
LIBMAIL to MAIL_LIB would fix the problem.  A more conventional
name to use for that variable would be LIBS_MAIL.  Does that name
work?

Re: Cannot link movemail on SunOS-5.5 in latest CVS

[Kenichi Handa]

Richard Stallman <rms@gnu.org> writes:
> There have not been a lot of changes in movemail lately.
> I don't see any changes that would cause this.
> It looks like Sun did something that broke it.

> It is exceedingly strange that simply renaming the Make variable
> LIBMAIL to MAIL_LIB would fix the problem.  A more conventional
> name to use for that variable would be LIBS_MAIL.  Does that name
> work?

lib-src/movemail.c includes src/config.h, and src/config.h
defines LIBMAIL as below on Solaris.

/* Define to -llockfile if it is usable. */
#define LIBMAIL -llockfile

And, that is perhaps because of this code in configure.in.
----------------------------------------------------------------------
# Check for mail-locking functions in a "mail" library
AC_CHECK_LIB(mail, maillock)
dnl Debian, at least:
dnl AC_CHECK_LIB(lockfile, maillock, [AC_DEFINE(HAVE_LIBMAIL)])
AC_CHECK_LIB(lockfile, maillock)
# If we have the shared liblockfile, assume we must use it for mail
# locking (e.g. Debian).  If we couldn't link against liblockfile
# (no liblockfile.a installed), ensure that we don't need to.
if test "$ac_cv_lib_lockfile_maillock" = no; then
  dnl This works for files generally, not just executables.
  dnl Should we look elsewhere for it?  Maybe examine /etc/ld.so.conf?
  AC_CHECK_PROG(liblockfile, liblockfile.so, yes, no,
                /usr/lib:/lib:/usr/local/lib:$LD_LIBRARY_PATH)
  if test $ac_cv_prog_liblockfile = yes; then
    AC_MSG_ERROR([Shared liblockfile found but can't link against it.
This probably means that movemail could lose mail.
There may be a \`development' package to install containing liblockfile.])
  else AC_DEFINE(LIBMAIL, -llockfile, [Define to -llockfile if it is usable.])
  fi
  else :
fi
----------------------------------------------------------------------

So, I think it's just an incidental collision of macro name.
Changing LIBMAIL to LIBS_MAIL should also work.

---
Ken'ichi HANDA
handa@etl.go.jp

Re: Cannot link movemail on SunOS-5.5 in latest CVS

[Vin Shelton]

I was not sure what the purpose of the configure.in change was.
I don't care what the makefile macro is named - LIBS_MAIL is fine with
me.

  - Vin

Kenichi Handa <handa@etl.go.jp> writes:
> Richard Stallman <rms@gnu.org> writes:
>> There have not been a lot of changes in movemail lately.
>> I don't see any changes that would cause this.
>> It looks like Sun did something that broke it.
>
>> It is exceedingly strange that simply renaming the Make variable
>> LIBMAIL to MAIL_LIB would fix the problem.  A more conventional
>> name to use for that variable would be LIBS_MAIL.  Does that name
>> work?
>
> lib-src/movemail.c includes src/config.h, and src/config.h
> defines LIBMAIL as below on Solaris.
>
> /* Define to -llockfile if it is usable. */
> #define LIBMAIL -llockfile
>
> And, that is perhaps because of this code in configure.in.
> ----------------------------------------------------------------------
> # Check for mail-locking functions in a "mail" library
> AC_CHECK_LIB(mail, maillock)
> dnl Debian, at least:
> dnl AC_CHECK_LIB(lockfile, maillock, [AC_DEFINE(HAVE_LIBMAIL)])
> AC_CHECK_LIB(lockfile, maillock)
> # If we have the shared liblockfile, assume we must use it for mail
> # locking (e.g. Debian).  If we couldn't link against liblockfile
> # (no liblockfile.a installed), ensure that we don't need to.
> if test "$ac_cv_lib_lockfile_maillock" = no; then
>   dnl This works for files generally, not just executables.
>   dnl Should we look elsewhere for it?  Maybe examine /etc/ld.so.conf?
>   AC_CHECK_PROG(liblockfile, liblockfile.so, yes, no,
>                 /usr/lib:/lib:/usr/local/lib:$LD_LIBRARY_PATH)
>   if test $ac_cv_prog_liblockfile = yes; then
>     AC_MSG_ERROR([Shared liblockfile found but can't link against it.
> This probably means that movemail could lose mail.
> There may be a \`development' package to install containing liblockfile.])
>   else AC_DEFINE(LIBMAIL, -llockfile, [Define to -llockfile if it is usable.])
>   fi
>   else :
> fi
> ----------------------------------------------------------------------
>
> So, I think it's just an incidental collision of macro name.
> Changing LIBMAIL to LIBS_MAIL should also work.
>
> ---
> Ken'ichi HANDA
> handa@etl.go.jp

Re: Cannot link movemail on SunOS-5.5 in latest CVS

[Richard Stallman]

Anyway, thanks for reporting the bug.