* Bad result from stat/fstat on W95
@ 2002-05-05 21:02 Juanma Barranquero
2002-05-06 13:45 ` Jason Rumney
0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2002-05-05 21:02 UTC (permalink / raw)
I´ve been trying to bootstrap Emacs (from CVS) on Windows 95 and I get
errors about C:/emacs/lisp/xxx.elc (for any xxx.el) not being writable,
and C:/emacs/lisp/ not being a directory.
I think the problem is related to one of these changes:
2002-04-28 Jason Rumney <jasonr@gnu.org>
* w32proc.c (syms_of_w32proc): Get true file attributes by default.
* w32.c (stat, fstat): Use file index information to generate
inodes for directories where available.
I´ve reverted the changes and after some fiddling I´ve got a working
Emacs.
AFAICS, the problem does not happen on W2K/XP.
--
Juanma Barranquero <lektu@terra.es>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bad result from stat/fstat on W95
2002-05-05 21:02 Bad result from stat/fstat on W95 Juanma Barranquero
@ 2002-05-06 13:45 ` Jason Rumney
2002-05-06 14:18 ` Juanma Barranquero
2002-05-25 23:47 ` Juanma Barranquero
0 siblings, 2 replies; 4+ messages in thread
From: Jason Rumney @ 2002-05-06 13:45 UTC (permalink / raw)
Cc: emacs-devel
Juanma Barranquero <lektu@terra.es> writes:
> I´ve been trying to bootstrap Emacs (from CVS) on Windows 95 and I get
> errors about C:/emacs/lisp/xxx.elc (for any xxx.el) not being writable,
> and C:/emacs/lisp/ not being a directory.
>
> I think the problem is related to one of these changes:
>
> 2002-04-28 Jason Rumney <jasonr@gnu.org>
>
> * w32proc.c (syms_of_w32proc): Get true file attributes by default.
>
> * w32.c (stat, fstat): Use file index information to generate
> inodes for directories where available.
I don't have access to a W9x system. Please try to debug what is
going wrong in stat or fstat. I was careful to catch errors returned
by the system calls, as support on W9x/ME is known to be lacking.
But perhaps they are returning successfully, but with invalid data.
Can we easily tell if the file index returned is invalid? (eg is it 0
in these cases; probably not or the code would work as before I think).
--
Jason Rumney
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bad result from stat/fstat on W95
2002-05-06 13:45 ` Jason Rumney
@ 2002-05-06 14:18 ` Juanma Barranquero
2002-05-25 23:47 ` Juanma Barranquero
1 sibling, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2002-05-06 14:18 UTC (permalink / raw)
Cc: emacs-devel
On 06 May 2002 14:45:43 +0100, Jason Rumney <jasonr@gnu.org> wrote:
> I don't have access to a W9x system. Please try to debug what is
> going wrong in stat or fstat.
I'll try to debug it, but it'll take a while; I only have W95 on my home
machine. BTW, that's a true W95, no 95a, 98 or Me, so perhaps it works
differently (i.e. "right" :) on those systems.
/L/e/k/t/u
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bad result from stat/fstat on W95
2002-05-06 13:45 ` Jason Rumney
2002-05-06 14:18 ` Juanma Barranquero
@ 2002-05-25 23:47 ` Juanma Barranquero
1 sibling, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2002-05-25 23:47 UTC (permalink / raw)
Cc: Jason Rumney
Jason Rumney <jasonr@gnu.org> writes:
> I don't have access to a W9x system. Please try to debug what is
> going wrong in stat or fstat. I was careful to catch errors returned
> by the system calls, as support on W9x/ME is known to be lacking.
> But perhaps they are returning successfully, but with invalid data.
> Can we easily tell if the file index returned is invalid? (eg is it 0
> in these cases; probably not or the code would work as before I think).
Finally I´ve found the time to debug it and I´ve found that the problem
happens exclusively when trying to write a non-existent file, because
the check to see the "writable status" of the directory on which it
would be written is failing.
I think the problem is the following line in stat() (w32.c ~ line 2209):
buf->st_mode = (wfd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) ?
_S_IFREG : _S_IFDIR;
because the condition seems to be reversed. If you agree I´ll commit the
patch to fix it.
Juanma
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-05-25 23:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-05 21:02 Bad result from stat/fstat on W95 Juanma Barranquero
2002-05-06 13:45 ` Jason Rumney
2002-05-06 14:18 ` Juanma Barranquero
2002-05-25 23:47 ` Juanma Barranquero
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.