shell-replace-by-expanded-directory bug when expanding =1/<TAB>

shell-replace-by-expanded-directory bug when expanding =1/<TAB>

[Trey Jackson]

This bug report will be sent to the Free Software Foundation,
 not to your local site managers!!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

In GNU Emacs 20.7.1 (i686-pc-linux-gnu, X toolkit)
 of Mon Oct 30 2000 on filc0021
configured using `configure  --prefix=/usr/intel/pkgs/emacs/20.7'

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

In shell mode, when you have a directory stack, the dirstack
completion introduces an extra slash.  e.g.  '=1/jou<TAB>' expands to
'/tmp/inv4_opt//jou' when it should expand to '/tmp/inv4_opt/jou' - at 
least if it's supposed to act all like tcsh.


Here's actual footage:

,----------------
| [dttlx120] inv4_opt 6> pushd
| ~ /tmp/inv4_opt 
| [dttlx120] ~ 7> ls /tmp/inv4_opt//jour
`----------------

A patch (two characters added) can be found at the end of this file.
Note: I patched the 21.1 version - because the bug is in that version as well. 
I just happen to run 20.7 on a regular basis.  The fix works in both versions.


Thanks.


TJ

Recent input:
h d l tab backspace tab backspace tab backspace C-a 
C-k l s return c d SPC i n v 4 _ o p t return l s return 
p u s h d return l s SPC = 1 / j o u r tab tab M-b 
C-a C-e C-a C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-e M-x e m a c SPC r e 
SPC p o backspace backspace backspace backspace backspace 
backspace backspace backspace backspace backspace backspace 
r e p o tab r t tab return

Recent messages:
Completing file name...
Loading ange-ftp...
Loading ange-ftp...done
No completions of /jour
Beginning of buffer
Making completion list...
Loading view...
Loading view...done
Loading emacsbug...
Loading emacsbug...done





-------------------------------------------------------------------
*** /usr/intel/pkgs/emacs/21.1/share/emacs/21.1/lisp/shell.el	Sat Jul 14 04:21:08 2001
--- shell.patched.el	Thu May  2 16:31:49 2002
***************
*** 996,1002 ****
  	(let ((stack (cons default-directory shell-dirstack))
  	      (index (cond ((looking-at "=-/?")
  			    (length shell-dirstack))
! 			   ((looking-at "=\\([0-9]+\\)")
  			    (string-to-number
  			     (buffer-substring
  			      (match-beginning 1) (match-end 1)))))))
--- 996,1002 ----
  	(let ((stack (cons default-directory shell-dirstack))
  	      (index (cond ((looking-at "=-/?")
  			    (length shell-dirstack))
! 			   ((looking-at "=\\([0-9]+\\)/?")
  			    (string-to-number
  			     (buffer-substring
  			      (match-beginning 1) (match-end 1)))))))

Re: shell-replace-by-expanded-directory bug when expanding =1/<TAB>

[Richard Stallman]

Thanks for fixing this.