From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog
Date: Mon, 01 Apr 2002 10:05:53 -0500
Sender: emacs-devel-admin@gnu.org
Message-ID: <200204011505.g31F5rM14334@rum.cs.yale.edu>
References: <E16r5bQ-0001Jp-00@subversions.gnu.org> <m3vgbe5wjm.fsf@Janik.cz> <200203311640.g2VGeFw10733@aztec.santafe.edu>  <m3vgbbye8q.fsf@Janik.cz>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Trace: main.gmane.org 1017673758 10107 127.0.0.1 (1 Apr 2002 15:09:18 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 1 Apr 2002 15:09:18 +0000 (UTC)
Cc: rms@gnu.org, emacs-devel@gnu.org
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 16s3Qr-0002cu-00
	for <emacs-devel@main.gmane.org>; Mon, 01 Apr 2002 17:09:17 +0200
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 16s3c7-0006Vv-00
	for <emacs-devel@quimby.gnus.org>; Mon, 01 Apr 2002 17:20:55 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 16s3Qe-00043j-00; Mon, 01 Apr 2002 10:09:04 -0500
Original-Received: from rum.cs.yale.edu ([128.36.229.169])
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 16s3Nb-0003kR-00; Mon, 01 Apr 2002 10:05:56 -0500
Original-Received: (from monnier@localhost)
	by rum.cs.yale.edu (8.11.6/8.11.6) id g31F5rM14334;
	Mon, 1 Apr 2002 10:05:53 -0500
X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4
Original-To: Pavel@Janik.cz (Pavel =?iso-8859-2?q?Jan=EDk?=)
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.8
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:2303
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:2303

> [ Redirected to emacs-devel. ]
> 
>    From: Richard Stallman <rms@gnu.org>
>    Date: Sun, 31 Mar 2002 09:40:15 -0700 (MST)
> 
>    >     Richard, play-sound is not guaranteed to exist.
>    > 
>    > Yes, I saw that.
>    > 
>    >     So it is not safe to make play-sound-file unconditional (we can remove
>    >     XEmacs comment though).
>    > 
>    > It seems safe to me.  If play-sound is not defined, play-sound-file
>    > will get an error trying to call it.  I think that is cleaner behavior
>    > than what happens if play-sound-file is not defined at all.
> 
> I think it would be much cleaner to:
> 
> - Fprovide (intern ("sound"), Qnil) in sound.c when `play-sound' is defined

Why would

	(featurep 'sound)

be any better than

	(fboundp 'play-sound)

??


	Stefan