From: Tak Ota <Takaaki.Ota@am.sony.com>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Choice for not using hollow box cursor
Date: Sat, 23 Mar 2002 12:45:56 -0800 (PST) [thread overview]
Message-ID: <20020323.124556.01366482.Takaaki.Ota@am.sony.com> (raw)
In-Reply-To: <5xeliozih8.fsf@kfs2.cua.dk>
13 Mar 2002 14:48:35 +0100: storm@cua.dk (Kim F. Storm) wrote:
> Richard Stallman <rms@gnu.org> writes:
>
> > Shouldn't it be the user choice? (the choice: blink between filled box
> > and hollow box or blink between filled box and blank).
> >
> > Is this user option really necessary? We should not add a new user
> > option just because its definition is meaningful and *someone* might
> > want it, because that would make Emacs even more bloated. We have to
> > *try* to keep the growth of user options in check, by adding only
> > those that are substantially important--those that we expect
> > more than a few users would want.
>
> There is already one user option: Turn off the blinking cursor.
I have been thinking how to achieve what I want without introducing a
new option. I want the cursor to be blinking because it is easy to
find it at a glance. But I don't want the hollow box cursor while it
blinks because it really obscures the character beneath it on my
display.
By default the hollow box cursor is used in non-selected buffers also,
so I turn it off by setting `cursor-in-non-selected-windows' to nil
as well.
I wonder if it is an acceptable behavior to disable hollow box cursor
when `cursor-in-non-selected-windows' is nil? I tried it and found
that it intuitively and visually made sense (although the logic is a
little bit mixed up) since `cursor-in-non-selected-windows' controls
the appearance/disappearance of hollow box cursor both in the selected
window and non-selected windows all together.
The patch for this is quite simple. Could you try and feel it?
-Tak
*** ../../tmp/emacs-21.2.50/src/xterm.c Fri Mar 22 07:52:48 2002
--- xterm.c Sat Mar 23 12:10:11 2002
***************
*** 11662,11668 ****
&new_cursor_width);
if (w->cursor_off_p)
{
! if (new_cursor_type == FILLED_BOX_CURSOR)
new_cursor_type = HOLLOW_BOX_CURSOR;
else if (new_cursor_type == BAR_CURSOR && new_cursor_width > 1)
new_cursor_width = 1;
--- 11662,11668 ----
&new_cursor_width);
if (w->cursor_off_p)
{
! if (new_cursor_type == FILLED_BOX_CURSOR && cursor_non_selected)
new_cursor_type = HOLLOW_BOX_CURSOR;
else if (new_cursor_type == BAR_CURSOR && new_cursor_width > 1)
new_cursor_width = 1;
[ota@TAK_4100 src]$ diff -c ../../tmp/emacs-21.2.50/src/w32term.c w32term.c
*** ../../tmp/emacs-21.2.50/src/w32term.c Fri Mar 22 20:58:02 2002
--- w32term.c Sat Mar 23 12:09:10 2002
***************
*** 9772,9778 ****
&new_cursor_width);
if (w->cursor_off_p)
{
! if (new_cursor_type == FILLED_BOX_CURSOR)
new_cursor_type = HOLLOW_BOX_CURSOR;
else if (new_cursor_type == BAR_CURSOR && new_cursor_width > 1)
new_cursor_width = 1;
--- 9772,9778 ----
&new_cursor_width);
if (w->cursor_off_p)
{
! if (new_cursor_type == FILLED_BOX_CURSOR && cursor_non_selected)
new_cursor_type = HOLLOW_BOX_CURSOR;
else if (new_cursor_type == BAR_CURSOR && new_cursor_width > 1)
new_cursor_width = 1;
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
prev parent reply other threads:[~2002-03-23 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-12 19:58 Choice for not using hollow box cursor Tak Ota
2002-03-13 10:58 ` Richard Stallman
2002-03-13 13:48 ` Kim F. Storm
2002-03-23 20:45 ` Tak Ota [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020323.124556.01366482.Takaaki.Ota@am.sony.com \
--to=takaaki.ota@am.sony.com \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.