Re: [mkoeppe@saturn.math.Uni-Magdeburg.DE: find-tag signals an error when a TAGS include file matches]

From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [mkoeppe@saturn.math.Uni-Magdeburg.DE: find-tag signals an error when a TAGS include file matches]
Date: Thu, 14 Mar 2002 05:42:45 -0700 (MST)	[thread overview]
Message-ID: <200203141242.g2ECgjT06217@wijiji.santafe.edu> (raw)
In-Reply-To: <E16l9hW-0004Ys-00@pot.cnuce.cnr.it> (message from Francesco Potorti` on Wed, 13 Mar 2002 15:25:58 +0100)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2299 bytes --]

    I think we can avoid installing this patch in the RC branch.  It is
    definitely a bug, but it stems from an obscure error condition, which I
    think is very rarely used.

I agree with you.  Any change installed in RC is a risk, and there is
no sense taking even a small risk to fix a bug that is obscure, rare
and not disastrous.

We should refrain from installing fixes for other non-disastrous bugs
in RC.

From: Francesco Potorti` <pot@gnu.org>
To: "Richard M. Stallman" <rms@gnu.org>
In-reply-to: <uw5k7sgeegw.fsf@lambda.math.uni-magdeburg.de> (mkoeppe@mail.Math.Uni-Magdeburg.De)
Subject: Re: [mkoeppe@saturn.math.Uni-Magdeburg.DE: find-tag signals an error
 when a TAGS include file matches]
Organization: 
X-fingerprint: 4B2 6187 5C3 D6B1 2E31  7666 9DF 2DC9 BE21 6115
Date: Wed, 13 Mar 2002 15:25:58 +0100

I think we can avoid installing this patch in the RC branch.  It is
definitely a bug, but it stems from an obscure error condition, which I
think is very rarely used.

Anyway, it is as safe as it can be, IMO, so if you want, I'll install it
in RC.

   Francesco Potorti` <pot@gnu.org> writes:

   >       I typed M-x visit-tags-table RET TAGS RET to visit the TAGS table
   >       reproduced below, which includes another tags file, TAGS-augm_gen.c. 
   >       Then I typed M-x find-tag RET augm_gen RET.  Emacs signalled an
   >       error.
   >
   > Thanks for your report.  Your diagnosis is correct, but I'd prefer the
   > following patch.  Would you please test it?
   >
   > --- etags.el.~1.155.4.2.~	Fri Feb 22 17:25:37 2002
   > +++ etags.el	Tue Mar 12 14:02:13 2002
   > @@ -1506,13 +1506,13 @@ where they were found."
   >  ;; exact file name match, i.e. searched tag must match complete file
   >  ;; name including directories parts if there are some.
   >  (defun tag-exact-file-name-match-p (tag)
   > -  (and (looking-at ",")
   > +  (and (looking-at ",[0-9]\\|\n")
   >         (save-excursion (backward-char (+ 2 (length tag)))
   >  		       (looking-at "\f\n"))))
   > [...]

   Your patch is also working fine for me.

   -- 
   Matthias Köppe -- http://www.math.uni-magdeburg.de/~mkoeppe

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel