From: "Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu>
Cc: "Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu>,
emacs-devel@gnu.org
Subject: Re: save-match-data woes
Date: Mon, 25 Feb 2002 03:21:07 -0500 [thread overview]
Message-ID: <200202250821.g1P8L7K14888@rum.cs.yale.edu> (raw)
In-Reply-To: 20020225090007.B039.LEKTU@terra.es
>
> On Fri, 22 Feb 2002 11:43:03 -0500, "Stefan Monnier" <monnier+gnu/emacs@RUM.cs.yale.edu> wrote:
>
> > I think this is a wrong approach. The match-data need only be saved
> > in a few particular circumstances and I'd rather handle those cases
> > in a special way.
>
> Well, I'm not so sure about the "few particular circumstances". I think
> is bad for a function to arbitrarily change the match data and not
> saving it and not even documenting that it does modify it. That's bound
> to cause trouble somewhere far away, where perhaps the trouble won't be
> so easily connected with match data. I have no hard data, but my gut
> feeling is that you will end saving/restoring match-data in many places
> just to protect you against the relatively few functions that do not do
> that now. What if one of your elisp modules is safely using a function
> in another module and its maintainer just modifies slightly the
> implementation, using now pp-to-string where he didn't before? Probably
> you weren't saving match data because you didn't see the reason... and I
> fail to see *why* you should have any reason now. It is not you who
> changed anything.
My experience is quite different: the match data is in 99% of the cases
used right after a call to a regexp-match function, with almost no
other functions called inbetween apart from some very primitive ones.
Why this is so is because many functions do regexp-matching and thus
destroy the match-data: the match-data is just very volatile. Another
reason why it's volatile is because any buffer modification can make
the match-data stale.
There are cases where it is important for the match-data to be preserved,
most notably in file-name-handlers (since various pieces of code rely
on the fact that the default implementation of file operations do not
do any regexp-matching). But for most other cases, preserving the
match-data is just a waste of time and it's almost always easier to
use the match-data right after pattern-matching rather than rely on
the match-data being preserved (and still meaningful) by a function
whose behavior might be changed without your knowing.
> (Unrelated:) On the matter of ielm, is there any objection to my patch
> of a few days back that makes ielm-prompt customizable and read-only?
I don't have any, hence my non-response.
Stefan
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2002-02-25 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-21 11:36 save-match-data woes Juanma Barranquero
2002-02-21 11:54 ` Eli Zaretskii
2002-02-22 16:43 ` Stefan Monnier
2002-02-23 5:26 ` Richard Stallman
2002-02-25 8:10 ` Juanma Barranquero
2002-02-25 8:21 ` Stefan Monnier [this message]
2002-02-25 10:19 ` Juanma Barranquero
2002-02-26 20:15 ` Richard Stallman
2002-02-27 10:00 ` Eli Zaretskii
2002-02-28 4:08 ` Richard Stallman
2002-02-26 20:14 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202250821.g1P8L7K14888@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.