From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme Date: Wed, 04 Jun 2014 21:09:50 -0400 Message-ID: <1zzjhsuppd.fsf@fencepost.gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1401930617 27512 80.91.229.3 (5 Jun 2014 01:10:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Jun 2014 01:10:17 +0000 (UTC) Cc: 17695@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 05 03:10:10 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WsMBz-0005Lt-VE for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jun 2014 03:10:08 +0200 Original-Received: from localhost ([::1]:37705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsMBz-0007OW-9c for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jun 2014 21:10:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsMBv-0007OE-Qq for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 21:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsMBv-0007VD-0c for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 21:10:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsMBu-0007Ul-SW for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 21:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WsMBu-0003hp-BK for bug-gnu-emacs@gnu.org; Wed, 04 Jun 2014 21:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jun 2014 01:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17695-submit@debbugs.gnu.org id=B17695.140193059414218 (code B ref 17695); Thu, 05 Jun 2014 01:10:02 +0000 Original-Received: (at 17695) by debbugs.gnu.org; 5 Jun 2014 01:09:54 +0000 Original-Received: from localhost ([127.0.0.1]:44529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsMBl-0003hG-P8 for submit@debbugs.gnu.org; Wed, 04 Jun 2014 21:09:54 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:39697 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsMBj-0003h5-KG for 17695@debbugs.gnu.org; Wed, 04 Jun 2014 21:09:52 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WsMBi-0005Kd-Nc; Wed, 04 Jun 2014 21:09:50 -0400 X-Spook: Albania bemd SWAT Al Jazeera e-cash Project Monarch X-Ran: Yl6[z)oyR24 (Leo Liu's message of "Thu, 05 Jun 2014 08:16:11 +0800") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90010 Archived-At: Leo Liu wrote: > 1. emacs -Q > 2. M-x load-theme RET deeper-blue RET > 3. open a patch in diff-mode. > > Face: diff-added (sample) (customize this face) I don't think this is a bug. The theme specifies attribute "nil" for this face (and some others). As NEWS says: *** Face specs set via Custom themes now replace the `defface' spec rather than inheriting from it So the theme gets what it asked for - every attribute unspecified. If this was not what the theme author intended, perhaps the theme should be changed. (As an aside, what is the difference between "regression" and "REGRESSION", and what is either supposed to actually mean in practice...)