all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Leo Liu <sdl.web@gmail.com>
Cc: 17695@debbugs.gnu.org
Subject: bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Wed, 04 Jun 2014 21:09:50 -0400	[thread overview]
Message-ID: <1zzjhsuppd.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m3tx802otw.fsf@gmail.com> (Leo Liu's message of "Thu, 05 Jun 2014 08:16:11 +0800")

Leo Liu wrote:

> 1. emacs -Q
> 2. M-x load-theme RET deeper-blue RET
> 3. open a patch in diff-mode.
>
> Face: diff-added (sample) (customize this face)

I don't think this is a bug.
The theme specifies attribute "nil" for this face (and some others).
As NEWS says:

  *** Face specs set via Custom themes now replace the `defface' spec
  rather than inheriting from it

So the theme gets what it asked for - every attribute unspecified.

If this was not what the theme author intended, perhaps the theme should
be changed.


(As an aside, what is the difference between "regression" and
"REGRESSION", and what is either supposed to actually mean in practice...)






  parent reply	other threads:[~2014-06-05  1:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  0:16 bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme Leo Liu
2014-06-05  0:39 ` Juri Linkov
2014-06-05  2:32   ` Leo Liu
2014-06-05 23:33     ` Juri Linkov
2014-06-06  9:28       ` Leo Liu
2014-06-06 23:07         ` Juri Linkov
2014-06-05  1:09 ` Glenn Morris [this message]
2014-06-05  2:40   ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1zzjhsuppd.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=17695@debbugs.gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.