all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* vc-set-mode-line-busy-indicator
@ 2008-02-25 12:46 Nick Roberts
  2008-02-25 20:25 ` vc-set-mode-line-busy-indicator Nick Roberts
  0 siblings, 1 reply; 70+ messages in thread
From: Nick Roberts @ 2008-02-25 12:46 UTC (permalink / raw)
  To: emacs-devel


The problem with this message is that it is so long that the bit after ("from
filename") doesn't fit in 80 columns.  Also a warning-face isn't really needed
because it doesn't provide a wake up call: the user has just entered a command,
e.g, vc-diff or vc-print-log, so presumably he's already looking for the output
buffer.

I've used the same style as I've used for the GUD buffer.  If text in the
mode-line is going to be increasingly fontified, it might be a good idea to
have some consistency.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** vc.el.~1.541.~	2008-02-24 08:24:18.000000000 +1300
--- vc.el	2008-02-26 01:29:24.000000000 +1300
*************** BUF defaults to \"*vc*\", can be a strin
*** 1064,1077 ****
  
  (defun vc-set-mode-line-busy-indicator ()
    (setq mode-line-process
! 	;; Deliberate overstatement, but power law respected.
! 	;; (The message is ephemeral, so we make it loud.)  --ttn
! 	(propertize " (incomplete/in progress)"
! 		    'face (if (featurep 'compile)
! 			      ;; ttn's preferred loudness
! 			      'compilation-warning
! 			    ;; suitably available fallback
! 			    font-lock-warning-face)
  		    'help-echo
  		    "A VC command is in progress in this buffer")))
  
--- 1064,1071 ----
  
  (defun vc-set-mode-line-busy-indicator ()
    (setq mode-line-process
! 	(propertize " [waiting...]"
! 		    'face 'font-lock-variable-name-face
  		    'help-echo
  		    "A VC command is in progress in this buffer")))
  




^ permalink raw reply	[flat|nested] 70+ messages in thread
* diff-mode misinterprets empty lines.
@ 2007-11-29  1:03 Richard Stallman
  2007-11-29  9:26 ` David Kastrup
  0 siblings, 1 reply; 70+ messages in thread
From: Richard Stallman @ 2007-11-29  1:03 UTC (permalink / raw)
  To: emacs-devel

This is important to fix.  Would someone please fix it in Emacs 22,
then ack?


X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
To: bug-gnu-emacs@gnu.org
From: Sergei Organov <osv@javad.com>
Date: Tue, 27 Nov 2007 21:04:17 +0300
Message-ID: <8763zno99a.fsf@osv.gnss.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: diff-mode misinterprets empty lines.

Hello,

In GNU Emacs 22.1.1 (i686-pc-linux-gnu, GTK+ Version 2.8.20).

GNU diff since version 2.8.7 outputs empty lines in the unified diff
format for empty context lines that don't change (instead of single
space followed by newline). See, e.g., the thread starting here:

<http://lists.gnu.org/archive/html/bug-gnu-utils/2006-09/msg00005.html>

Emacs diff-mode interprets empty lines as patch hunk separators, in
particular leading to wrong calculation of the length put into hunk
header. Another symptom is "C-c C-n" (diff-restrict-view) wrongly
restricts hunks with empty line(s).

Here is a patch hunk to test on:

@@ -1,7 +1,7 @@
 l1

 l3
-	  abc
+	  cba
 l5
 l6
 l7


-- 
Sergei Organov.

^ permalink raw reply	[flat|nested] 70+ messages in thread

end of thread, other threads:[~2008-03-11 20:24 UTC | newest]

Thread overview: 70+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-25 12:46 vc-set-mode-line-busy-indicator Nick Roberts
2008-02-25 20:25 ` vc-set-mode-line-busy-indicator Nick Roberts
2008-02-26  4:11   ` vc-set-mode-line-busy-indicator Glenn Morris
2008-02-26  7:38     ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-01 22:19       ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-01 22:26         ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-01 22:53           ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-02 16:12             ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-03  1:57               ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-03 17:13                 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03 21:23                   ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-03 23:27                     ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-02 17:25             ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-02 18:53               ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03 18:27                 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 18:58                   ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-04 17:38                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-04 18:39                       ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-05 21:33                         ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-05 21:50                           ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07  3:38                             ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-07  3:46                               ` vc-set-mode-line-busy-indicator Miles Bader
2008-03-07 17:46                                 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07 18:05                                   ` vc-set-mode-line-busy-indicator Jan Djärv
2008-03-07 18:50                                     ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07 22:18                                     ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-08  7:03                                       ` vc-set-mode-line-busy-indicator Jan Djärv
2008-03-08 17:39                                 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-08 18:57                                   ` Diffs between %s and %s end here (was: vc-set-mode-line-busy-indicator) Reiner Steib
2008-03-08 19:29                                     ` Diffs between %s and %s end here David Kastrup
2008-03-08 19:35                                       ` Dan Nicolaescu
2008-03-08 19:40                                         ` David Kastrup
2008-03-08 21:33                                       ` Juri Linkov
2008-03-08 21:39                                         ` Glenn Morris
2008-03-08 21:59                                           ` Juri Linkov
2008-03-08 23:41                                             ` Glenn Morris
2008-03-08 23:58                                               ` David Kastrup
2008-03-09  0:29                                                 ` Dan Nicolaescu
2008-03-09 10:10                                                   ` David Kastrup
2008-03-09 15:02                                                     ` Dan Nicolaescu
2008-03-09 16:40                                                   ` Richard Stallman
2008-03-09 16:39                                             ` Richard Stallman
2008-03-09 17:57                                               ` Juri Linkov
2008-03-10  6:12                                                 ` Richard Stallman
2008-03-11  0:20                                                   ` David Kastrup
2008-03-09 19:07                                               ` Glenn Morris
2008-03-10  3:02                                                 ` Stefan Monnier
2008-03-10  6:11                                                 ` Richard Stallman
2008-03-10 22:07                                                   ` Glenn Morris
2008-03-11 20:24                                                     ` Richard Stallman
2008-03-09 20:53                                     ` Diffs between %s and %s end here (was: vc-set-mode-line-busy-indicator) Richard Stallman
2008-03-09 22:39                                       ` Diffs between %s and %s end here Reiner Steib
2008-03-08 19:18                                   ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-09 16:40                                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-09 17:10                                       ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-09 16:40                                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-07  3:55                               ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03  1:56               ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-03 18:27                 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 21:04                   ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-04 17:37                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 23:27                   ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-04 17:38                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-04 19:29                       ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-04 22:33                         ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-05 21:33                         ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-02  5:53         ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-02  6:15           ` vc-set-mode-line-busy-indicator Nick Roberts
  -- strict thread matches above, loose matches on Subject: below --
2007-11-29  1:03 diff-mode misinterprets empty lines Richard Stallman
2007-11-29  9:26 ` David Kastrup
2007-11-29 16:09   ` Stefan Monnier
2007-12-05  7:35     ` Paul Eggert
2007-12-05 10:17       ` Jim Meyering
2007-12-05 10:58         ` David Kastrup
2007-12-05 11:27           ` Jim Meyering
2007-12-05 14:59             ` David Kastrup
2007-12-05 17:45               ` Paul Eggert
2007-12-05 21:04                 ` Juanma Barranquero
2007-12-06 15:39                   ` Stefan Monnier
2008-01-06  0:15                     ` Glenn Morris
2008-01-14 21:08                       ` Stefan Monnier
2008-01-14 21:38                         ` Glenn Morris
2008-01-14 22:46                           ` Glenn Morris
2008-01-14 23:35                             ` Diffs between %s and %s end here (was: diff-mode misinterprets empty lines.) Reiner Steib
2008-01-15  3:29                               ` Diffs between %s and %s end here Miles Bader
2008-01-16  8:13                                 ` Glenn Morris

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.