From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vegard Vesterheim Newsgroups: gmane.emacs.bugs Subject: bug#29116: 24.5; Parsing dates from VCAL Date: Mon, 06 Nov 2017 08:45:10 +0100 Organization: UNINETT AS Message-ID: <1sfu9r97g9.fsf@voll.uninett.no> References: <1smv459hy3.fsf@voll.uninett.no> <87mv41vxib.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1509954323 8519 195.159.176.226 (6 Nov 2017 07:45:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Nov 2017 07:45:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Cc: 29116@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 06 08:45:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBc5q-0001oA-1g for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 08:45:14 +0100 Original-Received: from localhost ([::1]:46837 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBc5v-0004DP-Bv for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 02:45:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBc5j-0004BS-7d for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 02:45:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBc5e-0004kk-CA for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 02:45:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44245) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBc5e-0004kb-8T for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 02:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBc5e-0002dM-1p for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 02:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vegard Vesterheim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2017 07:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29116-submit@debbugs.gnu.org id=B29116.150995428710086 (code B ref 29116); Mon, 06 Nov 2017 07:45:01 +0000 Original-Received: (at 29116) by debbugs.gnu.org; 6 Nov 2017 07:44:47 +0000 Original-Received: from localhost ([127.0.0.1]:52926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBc5N-0002ca-3c for submit@debbugs.gnu.org; Mon, 06 Nov 2017 02:44:47 -0500 Original-Received: from mailgw01.it.ntnu.no ([129.241.56.174]:37396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBc5K-0002cQ-L1 for 29116@debbugs.gnu.org; Mon, 06 Nov 2017 02:44:43 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mailgw01.it.ntnu.no (Postfix) with ESMTP id 2A98F242378; Mon, 6 Nov 2017 08:44:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mailgw01.it.ntnu.no Original-Received: from mailgw01.it.ntnu.no ([127.0.0.1]) by localhost (mailgw01.it.ntnu.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6VNgZSn315Rv; Mon, 6 Nov 2017 08:44:35 +0100 (CET) Original-Received: from voll.uninett.no (voll.uninett.no [158.38.62.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vegarve) by mailgw01.it.ntnu.no (Postfix) with ESMTPSA id 46B9424236D; Mon, 6 Nov 2017 08:44:35 +0100 (CET) In-Reply-To: <87mv41vxib.fsf@gmail.com> (Robert Pluim's message of "Sun, 05 Nov 2017 11:19:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139495 Archived-At: --=-=-= Content-Type: text/plain On Sun, 05 Nov 2017 11:19:08 +0100 Robert Pluim wrote: > Vegard Vesterheim writes: >> Looking at the backtrace it seems that the problem is related to parsing >> the date string: "20171208". > > timezone-parse-date assumes that the time-of-day is present in the > string to be parsed, which is not the case here. Looking at the code > icalendar should set the time to "00000" in that case. Would you have > a complete example VCAL file? Attached: --=-=-= Content-Type: text/x-vcalendar Content-Disposition: inline; filename=cal.ical BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:W. Europe Standard Time BEGIN:STANDARD DTSTART:16010101T030000 TZOFFSETFROM:+0200 TZOFFSETTO:+0100 RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T020000 TZOFFSETFROM:+0100 TZOFFSETTO:+0200 RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=3 END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT ATTENDEE;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=TRUE;CN=Vegard Ves terheim:MAILTO:vegard.vesterheim@uninett.no DESCRIPTION;LANGUAGE=en-US:Meeting description SUMMARY;LANGUAGE=en-US:Re-certification DTSTART;VALUE=DATE:20171208 DTEND;VALUE=DATE:20171209 UID:040000008200E00074C5B7101A82E00800000000434E72372153D301000000000000000 010000000B8E13E691E414545A6B9D006B49136EC CLASS:PUBLIC PRIORITY:5 DTSTAMP:20171101T145345Z TRANSP:OPAQUE STATUS:CONFIRMED SEQUENCE:0 LOCATION;LANGUAGE=en-US:UNINETT 5.etg Perl [vbro.no/Perl] (260.502) X-MICROSOFT-CDO-APPT-SEQUENCE:0 X-MICROSOFT-CDO-OWNERAPPTID:2115701571 X-MICROSOFT-CDO-BUSYSTATUS:TENTATIVE X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY X-MICROSOFT-CDO-ALLDAYEVENT:TRUE X-MICROSOFT-CDO-IMPORTANCE:1 X-MICROSOFT-CDO-INSTTYPE:0 X-MICROSOFT-DISALLOW-COUNTER:FALSE END:VEVENT END:VCALENDAR --=-=-= Content-Type: text/plain My naive workaraound for this bug was to modify the function gnus-icalendar-event--decode-datafile: (defun gnus-icalendar-event--decode-datefield (ical field) (let* ((date (icalendar--get-event-property ical field)) (date-props (icalendar--get-event-property-attributes ical field)) (tz (plist-get date-props 'TZID))) ;; VVWASHERE-start, fix bug in parsing DATE (and (eq (car date-props) 'VALUE) (string= (car (cdr date-props)) "DATE") (setq date (concat date "T00:00"))) ;; VVWASHERE-end, fix bug in parsing DATE (cdr date-props) (date-to-time (timezone-make-date-arpa-standard date nil tz)))) -- - Vegard V - --=-=-=--