From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#27346: module tests fail to compile with gcc 4.8.5 Date: Mon, 12 Jun 2017 16:28:55 -0400 Message-ID: <1fvao16jco.fsf@fencepost.gnu.org> References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1497299413 14039 195.159.176.226 (12 Jun 2017 20:30:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Jun 2017 20:30:13 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 27346@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 12 22:30:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVyT-0003LB-CM for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jun 2017 22:30:09 +0200 Original-Received: from localhost ([::1]:39917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKVyX-0005CZ-6l for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jun 2017 16:30:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKVyR-0005BB-Hq for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2017 16:30:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKVyN-00075i-2y for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2017 16:30:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dKVyM-00075e-Vy for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2017 16:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dKVyM-0000Vl-P7 for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2017 16:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jun 2017 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27346 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27346-submit@debbugs.gnu.org id=B27346.14972993441877 (code B ref 27346); Mon, 12 Jun 2017 20:30:02 +0000 Original-Received: (at 27346) by debbugs.gnu.org; 12 Jun 2017 20:29:04 +0000 Original-Received: from localhost ([127.0.0.1]:44063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVxQ-0000UC-Ha for submit@debbugs.gnu.org; Mon, 12 Jun 2017 16:29:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVxO-0000Th-S5 for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 16:29:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKVxI-0006ZA-OH for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 16:28:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKVxI-0006Yw-KU for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 16:28:56 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKVxH-0006zS-Pj; Mon, 12 Jun 2017 16:28:55 -0400 X-Spook: Drug war La Familia Metro Peking Shell Quarnantine X-Ran: =gHn{v}!_W%7SdzT+d<9QPev#HY[$"%JS/&4g%3}"L:O/BJfxF]Txxa11K^0@%scQIh~ (Eli Zaretskii's message of "Mon, 12 Jun 2017 21:25:15 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133534 Archived-At: Eli Zaretskii wrote: > I think the "if defined __has_attribute &&" part is not needed, since > conf_post.h defines it fr compilers that lack it. Can you try that? emacs-module.h does not include config.h, and I don't know if it should. (I see no src/*.h file includes config.h, except cygw32.h. Should it? It could easily be changed not to.) If not, then I guess something like the following is needed: --- a/src/emacs-module.h +++ b/src/emacs-module.h @@ -35,9 +35,12 @@ # define EMACS_NOEXCEPT #endif -#if defined __has_attribute && __has_attribute(__nonnull__) +#ifdef __has_attribute +#if __has_attribute(__nonnull__) # define EMACS_ATTRIBUTE_NONNULL(...) __attribute__((__nonnull__(__VA_ARGS__))) -#else +#endif +#endif +#ifndef EMACS_ATTRIBUTE_NONNULL # define EMACS_ATTRIBUTE_NONNULL(...) #endif (Even with this change or your suggestion, I then get "Module initialization failed" when running the tests, but that's probably a different issue.)