From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode' Date: Tue, 26 May 2020 13:02:04 -0700 (PDT) Message-ID: <1fd3ebe3-e447-43af-8086-32a98febe475@default> References: <87lfpu9ag8.fsf@marxist.se> <87367qmm0l.fsf@gmail.com> <323e521b-503b-4ed3-bd42-aa3707de37c1@default> <87sgfmfv6v.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="46415"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Matthias Meulien , Stefan Kangas , 39293@debbugs.gnu.org To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 26 22:02:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdfmE-000Bx0-6W for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 22:02:18 +0200 Original-Received: from localhost ([::1]:38210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdfmD-0000ZY-4A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 May 2020 16:02:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdfly-0000Yz-6S for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 16:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdflx-00076b-Rv for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 16:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdflx-0003St-Px for bug-gnu-emacs@gnu.org; Tue, 26 May 2020 16:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 May 2020 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39293-submit@debbugs.gnu.org id=B39293.159052326913260 (code B ref 39293); Tue, 26 May 2020 20:02:01 +0000 Original-Received: (at 39293) by debbugs.gnu.org; 26 May 2020 20:01:09 +0000 Original-Received: from localhost ([127.0.0.1]:46404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdfl7-0003Ro-BB for submit@debbugs.gnu.org; Tue, 26 May 2020 16:01:09 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:59310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdfl5-0003RO-JG for 39293@debbugs.gnu.org; Tue, 26 May 2020 16:01:08 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04QJx0QP180189; Tue, 26 May 2020 20:01:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=+GYOEe6380LD2+8dA6h57aDN78i4edJLeUZkUhhsXDU=; b=ulKjnbhTHFDb3hA2nPEb++iMybHIEgByz5gJRK+8yzDu3XQv8B/g6uKRLMKKQonY9wkR aVZO5fQ5woPcr8UvjqPCek8SrSi6PSkXp+kj2nqa2s4BeOF/njxmu/bmeyEPxYY2d/+D 37t8KmyW7Lrqwt1FHcMxrjCGVKgj23oVt3/jkE+9TuNO8xgPDMfWeoWigeN27fDnpmzt WkUarJ/XIDkpF4TrFnN8lG77UdodmOHz+eZlWUZQ7qkYzhA3w96XPJ/pdOFymmZpx+Qw jBvj4hjJL62QXJfGcauBicedJA3P99UEyzNDUb5xE9ugL3WVo/84GFb/TFFvBa/dnLwk jg== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 318xe1bwck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 May 2020 20:01:01 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04QJvcQr192653; Tue, 26 May 2020 20:01:00 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 317dkt3117-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 May 2020 20:01:00 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 04QK0vbw015229; Tue, 26 May 2020 20:00:57 GMT In-Reply-To: <87sgfmfv6v.fsf@red-bean.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5005.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9633 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005260155 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9633 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 adultscore=0 cotscore=-2147483648 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005260155 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181069 Archived-At: > I too would like to hear what specifically would be limited or broken > by switching to use `tabulated-list-mode' here. >=20 > This does not mean I'm necessarily in favor of applying the patch; I > just think Stefan's question is important, and I don't see it given a > concrete answer anywhere. What would break in Bookmark+ if this patch > were applied to bookmark.el, and/or what new limitations would > bookmark.el after this patch? >=20 > IOW, I'd just like to understand the tradeoffs better here. Sorry, I really don't have the time to deal with this now. Bookmark+ has lots of added features, and many have to do with the bookmark-list display. If you're interested in that, please see its doc. Maybe at some point later I'll have the time and will to tick off things in Bookmark+ that t-l-mode interferes with or prohibits. I think at this point you'll just have to take my word for it (or not) that it would be far too much work, too risky, and for no benefit, for me to try to rewrite such features to adapt to t-l-mode. And I'm pretty sure that some things would need to be sacrificed. In my experience just with `apu.el' (which uses t-l-mode) I ran into limitations that I had to work around (no, I don't recall what they were). [Can a t-l-mode buffer even have a title (not just column headings)? With Bookmark+ the listing reflects the current sorting and filterings, and the title at the top tells you what the listing is about.] I'm sorry to say it, but I won't try, for Bookmark+. I don't have the time to waste on that. Sorry. Do what you think you have to do. I'll do what I have to do, given my limited resources. I expect I'll likely just incorporate the former bookmark.el code that Bookmark+ currently takes for granted. ___ FWIW, I also don't think that bookmark.el's list of bookmarks is a great candidate for t-l-mode. I don't think it adds anything important for such a simple list with 2-3 columns. As I said in my Jan 26 mail, sorting by those columns (which is really all that t-l-mode offers here) is not so helpful. (OK, it has some use.) Maybe consider ibuffer.el instead? As I said earlier, trying ibuffer, which offers a bit more than a rudimentary listing, might point to some t-l-mode limitations or complications. And if it doesn't then so much the better. ;-) ___ To be clear, I don't think I said that anything would be limited or broken in _bookmark.el_ by using t-l-mode. Potential uses of its features, and existing uses by 3rd-party libraries (e.g. Bookmark+), could be limited or broken. But I doubt that anything bookmark.el offers out of the box would be affected much, if at all. (bookmark.el could probably drop a good deal of its code without breaking anything that people use much). Thx - Drew