1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
| | ;;; dired-aux-tests.el --- Test suite for dired-aux. -*- lexical-binding: t -*-
;; Copyright (C) 2017-2021 Free Software Foundation, Inc.
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
;;; Code:
(require 'ert)
(require 'dired-aux)
(eval-when-compile (require 'cl-lib))
(ert-deftest dired-test-bug27496 ()
"Test for https://debbugs.gnu.org/27496 ."
(skip-unless (executable-find shell-file-name))
(let* ((foo (make-temp-file "foo"))
(files (list foo)))
(unwind-protect
(cl-letf (((symbol-function 'read-char-from-minibuffer) 'error))
(dired temporary-file-directory)
(dired-goto-file foo)
;; `dired-do-shell-command' returns nil on success.
(should-error (dired-do-shell-command "ls ? ./?" nil files))
(should-error (dired-do-shell-command "ls ./? ?" nil files))
(should-not (dired-do-shell-command "ls ? ?" nil files))
(should-error (dired-do-shell-command "ls * ./*" nil files))
(should-not (dired-do-shell-command "ls * *" nil files))
(should-not (dired-do-shell-command "ls ? ./`?`" nil files)))
(delete-file foo))))
;; Auxiliary macro for `dired-test-bug28834': it binds
;; `dired-create-destination-dirs' to CREATE-DIRS and execute BODY.
;; If YES-OR-NO is non-nil, it binds `yes-or-no-p' to
;; to avoid the prompt.
(defmacro with-dired-bug28834-test (create-dirs yes-or-no &rest body)
(declare (debug (form symbolp body)))
(let ((foo (make-symbol "foo")))
`(let* ((,foo (make-temp-file "foo" 'dir))
(dired-create-destination-dirs ,create-dirs))
(setq from (make-temp-file "from"))
(setq to-cp
(expand-file-name
"foo-cp" (file-name-as-directory (expand-file-name "bar" ,foo))))
(setq to-mv
(expand-file-name
"foo-mv" (file-name-as-directory (expand-file-name "qux" ,foo))))
(unwind-protect
(if ,yes-or-no
(cl-letf (((symbol-function 'yes-or-no-p)
(lambda (_prompt) (eq ,yes-or-no 'yes))))
,@body)
,@body)
;; clean up
(delete-directory ,foo 'recursive)
(delete-file from)))))
(ert-deftest dired-test-bug28834 ()
"test for https://debbugs.gnu.org/28834 ."
(let (from to-cp to-mv)
;; `dired-create-destination-dirs' set to 'always.
(with-dired-bug28834-test
'always nil
(dired-copy-file-recursive from to-cp nil)
(should (file-exists-p to-cp))
(dired-rename-file from to-mv nil)
(should (file-exists-p to-mv)))
;; `dired-create-destination-dirs' set to nil.
(with-dired-bug28834-test
nil nil
(should-error (dired-copy-file-recursive from to-cp nil))
(should-error (dired-rename-file from to-mv nil)))
;; `dired-create-destination-dirs' set to 'ask.
(with-dired-bug28834-test
'ask 'yes ; Answer `yes'
(dired-copy-file-recursive from to-cp nil)
(should (file-exists-p to-cp))
(dired-rename-file from to-mv nil)
(should (file-exists-p to-mv)))
(with-dired-bug28834-test
'ask 'no ; Answer `no'
(should-error (dired-copy-file-recursive from to-cp nil))
(should-error (dired-rename-file from to-mv nil)))))
(ert-deftest dired-test-bug30624 ()
"test for https://debbugs.gnu.org/30624 ."
(cl-letf* ((target-dir (make-temp-file "target" 'dir))
((symbol-function 'dired-mark-read-file-name)
(lambda (&rest _) target-dir))
(inhibit-message t))
;; Delete target-dir: `dired-do-create-files' must recreate it.
(delete-directory target-dir)
(let ((file1 (make-temp-file "bug30624_file1"))
(file2 (make-temp-file "bug30624_file2"))
(dired-create-destination-dirs 'always)
(buf (dired temporary-file-directory)))
(unwind-protect
(progn
(dired-revert)
(dired-mark-files-regexp "bug30624_file")
(dired-do-create-files 'copy 'dired-copy-file "Copy" nil)
(should (dired-move-to-filename)))
(delete-directory target-dir 'recursive)
(mapc #'delete-file `(,file1 ,file2))
(kill-buffer buf)))))
(defun dired-test--check-highlighting (command positions)
(let ((start 1))
(dolist (pos positions)
(should-not (text-property-not-all start (1- pos) 'face nil command))
(should (equal 'warning (get-text-property pos 'face command)))
(setq start (1+ pos)))
(should-not (text-property-not-all
start (length command) 'face nil command))))
(ert-deftest dired-test-highlight-metachar ()
"Check that non-isolated meta-characters are highlighted."
(let* ((command "sed -r -e 's/oo?/a/' -e 's/oo?/a/' ? `?`")
(markers " ^ ^")
(result (dired--highlight-no-subst-chars
(dired--need-confirm-positions command "?")
command
t))
(lines (split-string result "\n")))
(should (= (length lines) 2))
(should (string-match (regexp-quote command) (nth 0 lines)))
(should (string-match (regexp-quote markers) (nth 1 lines)))
(dired-test--check-highlighting (nth 0 lines) '(15 29)))
;; Note that `?` is considered isolated, but `*` is not.
(let* ((command "sed -e 's/o*/a/' -e 's/o`*` /a/'")
(markers " ^ ^")
(result (dired--highlight-no-subst-chars
(dired--need-confirm-positions command "*")
command
t))
(lines (split-string result "\n")))
(should (= (length lines) 2))
(should (string-match (regexp-quote command) (nth 0 lines)))
(should (string-match (regexp-quote markers) (nth 1 lines)))
(dired-test--check-highlighting (nth 0 lines) '(11 25)))
(let* ((command "sed 's/\\?/!/'")
(result (dired--highlight-no-subst-chars
(dired--need-confirm-positions command "?")
command
nil))
(lines (split-string result "\n")))
(should (= (length lines) 1))
(should (string-match (regexp-quote command) (nth 0 lines)))
(dired-test--check-highlighting (nth 0 lines) '(8))))
(provide 'dired-aux-tests)
;; dired-aux-tests.el ends here
|