From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: Emacs HEAD broken with XPM option in 1b492fa Date: Mon, 4 Sep 2017 20:45:51 -0400 Message-ID: <1fa1d96e-e703-9886-47b4-67ab13063cfd@cornell.edu> References: <86vakz8nik.fsf@chateau.d.if> <4c5e3148-ca98-f010-8fa9-f3b02f3eca88@cs.ucla.edu> <83bmmq2u6i.fsf@gnu.org> <867exejmrm.fsf@chateau.d.if> <863782jmif.fsf@chateau.d.if> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1504572361 9707 195.159.176.226 (5 Sep 2017 00:46:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Sep 2017 00:46:01 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 Cc: Paul Eggert , npostavs@gmail.com, emacs-devel@gnu.org To: Ashish SHUKLA , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 05 02:45:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dp1zd-00013B-EH for ged-emacs-devel@m.gmane.org; Tue, 05 Sep 2017 02:45:29 +0200 Original-Received: from localhost ([::1]:56219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dp1zk-0001fL-Jw for ged-emacs-devel@m.gmane.org; Mon, 04 Sep 2017 20:45:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dp1zX-0001er-3W for emacs-devel@gnu.org; Mon, 04 Sep 2017 20:45:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dp1zS-0000lT-AB for emacs-devel@gnu.org; Mon, 04 Sep 2017 20:45:23 -0400 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:52510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dp1zS-0000l3-4v; Mon, 04 Sep 2017 20:45:18 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v850jE7W003280; Mon, 4 Sep 2017 20:45:14 -0400 Original-Received: from [192.168.0.5] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v850jBp4001699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 4 Sep 2017 20:45:12 -0400 In-Reply-To: <863782jmif.fsf@chateau.d.if> Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 128.84.13.243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217934 Archived-At: On 9/4/2017 3:23 PM, Ashish SHUKLA wrote: > On Tue, 05 Sep 2017 00:48:21 +0530, ashish.is@lostca.se (Ashish SHUKLA) said: > | On Mon, 04 Sep 2017 21:30:13 +0300, Eli Zaretskii said: > | || From: Paul Eggert > | || Date: Mon, 4 Sep 2017 10:50:37 -0700 > | || Cc: Noam Postavsky > | || > | || > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/): > | || > | || A comment before that line says: > | || > | || ### The Cygwin-w32 build uses instead of , so > | || ### we need to set LDFLAGS accordingly. > | || > | || so presumably the noX is intentional. Perhaps this depends on Cygwin versions? > | || Sorry, I can't be of much help here since I don't use Cygwin. > > | | The OP was evidently compiling for FreeBSD, so I wonder how that > | | compilation ends up in a Cygwin-specific part of the configure > | | script. I guess some configure-time logic misfires on FreeBSD? > > | Well, if you look carefully, there are two checks involving "noX/xpm.h" code > | snippet, one is for Windows/non-X11, and another is for X11. And, > | unfortunately both of those checks check for "noX/xpm.h", which I think is > | unintentional, and typo on author's part. > > At following lines to be precise: > > http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3326 This use of "noX" is correct and is for the Cygwin-w32 build. > http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3356 This one is wrong. It's surprising that it hasn't been noticed until now. I'll fix it shortly if no one beats me to it. Ken