From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'? Date: Sat, 16 Sep 2023 21:42:14 -0700 Message-ID: <1f9e98be-3248-56cf-b7fd-8301666675c6@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11323"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com To: 66041@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 17 06:43:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhjcy-0002rG-5E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Sep 2023 06:43:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhjch-0003nT-Hl; Sun, 17 Sep 2023 00:43:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhjcb-0003k4-Dl for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 00:43:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhjcV-0000e0-8O for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 00:42:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhjcc-000332-AF; Sun, 17 Sep 2023 00:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: joaotavora@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Sep 2023 04:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66041 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: joaotavora@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.169492576411685 (code B ref -1); Sun, 17 Sep 2023 04:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Sep 2023 04:42:44 +0000 Original-Received: from localhost ([127.0.0.1]:48859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhjcJ-00032O-G9 for submit@debbugs.gnu.org; Sun, 17 Sep 2023 00:42:43 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:43578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhjcD-000328-VE for submit@debbugs.gnu.org; Sun, 17 Sep 2023 00:42:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhjc0-0003h4-T0 for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 00:42:25 -0400 Original-Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhjbx-0000ZH-8h for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 00:42:24 -0400 Original-Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-68cbbff84f6so3153904b3a.1 for ; Sat, 16 Sep 2023 21:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694925739; x=1695530539; darn=gnu.org; h=content-transfer-encoding:to:subject:from:content-language :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=t0zDzylKaTWz2JzJYCLLuJ3WB0deWqEDQmUQ/MB9GJo=; b=bLrHRbUG1NdZ2kS9opntru1+SkjlJ5pB+Q4on6bQ80D4/uS3/en8buVPoKoigQW/7K 2haiRqLEcWk/rDCqCdhNwg5ApCHmQDOm5oHsatnUjv8d6H39BwEY5Vs6PxZvW9s9J+fY ei872BCGZBKmvvt64mJ4tj7ISf/t5QJIOywgwDgLMnB7abNrJl2kPap8iHxNjw0vf4ZP 3GqESJJ2XfcehuqXhqD58ACvzpOcSe56Ed42mUZmHjXBPj66fDJ3qIgl7F1DNJde9ayw 5PZVxW3Jws1G7mrlYhtN4gI4YX1Iihbzv9JLthX6SWTwCRbkaHdXSlfbWdWHqK7QT9t3 zk7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694925739; x=1695530539; h=content-transfer-encoding:to:subject:from:content-language :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=t0zDzylKaTWz2JzJYCLLuJ3WB0deWqEDQmUQ/MB9GJo=; b=rH7+4SggN+emd5/+VnoVD8cJj5Cmc9eVCcRA8fa70v6sonsFKFj+sh0wLL3TTZb23p dKD4st/7gRNRzHv3zM2od4mjrw3En7VGvJ+HOPU+kIeKvt0BLCmlCyYKUM7vDFerBVVm p9sjlO3eBN0+VpXGrdKPci5bcVmVPUyxmGq4omqpakVsUIuBgwsI9hZggBg1lscm6lSh gSU8HhqHS5S8AGe8a15nzxSBHYpy9hVVA1p/A+eUnZ7hPrsnl0JOKyMc/p5DNDcYEuM2 FXohBJCj/CioqSkRHlRf8eKYH+/Qod2NWy2eaZzZ0JkOCvJX8/kZOXuwLk5meFwcPDqc ZQ/g== X-Gm-Message-State: AOJu0YyDmBRET/5Arp5joxOrnppQapAX9Gwa+Lekh4qZTRG505cL/imB qGZCGDruyXf7jnyeti6ovhR2HAN/D0a8wg== X-Google-Smtp-Source: AGHT+IG56wJ/4rHcSZuUSiWqHIlX7ECEd+1+gHQYKdUpPA6r38fQ2riBnQyiweL3ELH0yOznK6fxYg== X-Received: by 2002:a05:6a20:72a3:b0:14d:e615:277c with SMTP id o35-20020a056a2072a300b0014de615277cmr7061550pzk.11.1694925739389; Sat, 16 Sep 2023 21:42:19 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ff16-20020a056a002f5000b0068fedfe01fesm5156396pfb.161.2023.09.16.21.42.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Sep 2023 21:42:19 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270662 Archived-At: X-Debbugs-Cc: joaotavora@gmail.com The faces 'flymake-error-echo' and 'flymake-warning-echo' inherit from 'compilation-error' and 'compilation-warning', respectively. However, 'flymake-note-echo' (and 'flymake-note-echo-at-eol') inherit from 'flymake-note'. This results in some odd visuals in "emacs -Q" (and any theme that uses similar styling): Flymake errors and warnings in the mode-line (or the minibuffer/end-of-line) are red or orange text. However, Flymake notes are the default text color with a green wavey underline. Especially when they're side-by-side in the mode-line, the current visuals are surprising (not to mention hard to see in the default theme). Personally, I think it'd be better for the "echo" faces for Flymake notes to just inherit from 'compilation-info'. They have almost identical uses as far as I can tell, and then things would look more consistent/readable. (In fact, we could even rename flymake-note to flymake-info, but maybe that ship has sailed.)