From: Paul Eggert <eggert@cs.ucla.edu>
To: Federico <federicotedin@gmail.com>, emacs-devel@gnu.org
Subject: Re: Can't build Emacs on master branch
Date: Sun, 19 Aug 2018 10:08:34 -0700 [thread overview]
Message-ID: <1f958d58-3d15-243f-dbdd-8bfcaeb4766a@cs.ucla.edu> (raw)
In-Reply-To: <CAA8GjPkwzBdynRzJSK-iUhvO1ABfy7UMWHBX38fTfovd-9EKeg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
Federico wrote:
> calc/calc-aent.el:28:1:Error: Arithmetic range error: "expt", 10, 9
Thanks for reporting it, as it didn't happen on the platform I was testing with.
I installed the attached, which should fix it.
[-- Attachment #2: 0001-Fix-expt-signedness-bug-without-wide-int.patch --]
[-- Type: text/x-patch, Size: 1036 bytes --]
From ecd7a9407711ebe24d7e07d4402a2d66754ee693 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 19 Aug 2018 10:05:41 -0700
Subject: [PATCH] Fix expt signedness bug --without-wide-int
Problem reported by Federico in:
https://lists.gnu.org/r/emacs-devel/2018-08/msg00619.html
* src/floatfns.c (Fexpt): Use TYPE_RANGED_FIXNUMP, not
RANGED_FIXNUMP, to fix bug with unsigned comparison on
platforms built --without-wide-int.
---
src/floatfns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/floatfns.c b/src/floatfns.c
index 54d068c29e..7c52a0a9a2 100644
--- a/src/floatfns.c
+++ b/src/floatfns.c
@@ -212,7 +212,7 @@ DEFUN ("expt", Fexpt, Sexpt, 2, 2, 0,
if (INTEGERP (arg1) && NATNUMP (arg2))
{
unsigned long exp;
- if (RANGED_FIXNUMP (0, arg2, ULONG_MAX))
+ if (TYPE_RANGED_FIXNUMP (unsigned long, arg2))
exp = XFIXNUM (arg2);
else if (MOST_POSITIVE_FIXNUM < ULONG_MAX && BIGNUMP (arg2)
&& mpz_fits_ulong_p (XBIGNUM (arg2)->value))
--
2.17.1
next prev parent reply other threads:[~2018-08-19 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 16:33 Can't build Emacs on master branch Federico
2018-08-19 17:08 ` Paul Eggert [this message]
2018-08-19 18:02 ` Federico Tedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f958d58-3d15-243f-dbdd-8bfcaeb4766a@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=federicotedin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.