From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: mituharu@math.s.chiba-u.ac.jp Newsgroups: gmane.emacs.bugs Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 Date: Sun, 5 May 2019 09:10:38 +0900 Message-ID: <1f69e048f5d28aeab38a2e21320e3f26.squirrel@weber.math.s.chiba-u.ac.jp> References: <877ebeor2d.fsf@gmail.com> <83tveit5ph.fsf@gnu.org> <87pnp5oqu1.fsf@gmail.com> <877ebcogg4.fsf@gmail.com> <83sgu0rsue.fsf@gnu.org> <8736lznzjf.fsf@gmail.com> <83zho6ox5u.fsf@gnu.org> <878svomynv.fsf@gmail.com> <838svmmy5q.fsf@gnu.org> <87pnoyj9wh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-2022-jp Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205181"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.22-5.el6 Cc: 35468@debbugs.gnu.org To: "Alex Gramiak" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 05 02:11:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hN4kI-000rG6-Ik for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 May 2019 02:11:10 +0200 Original-Received: from localhost ([127.0.0.1]:34340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hN4kH-000732-GE for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 20:11:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hN4kB-00072t-UU for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 20:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hN4kA-0002jG-VE for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 20:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39133) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hN4kA-0002j7-S8 for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 20:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hN4kA-0001Ld-Mi for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 20:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: mituharu@math.s.chiba-u.ac.jp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2019 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35468-submit@debbugs.gnu.org id=B35468.15570150415146 (code B ref 35468); Sun, 05 May 2019 00:11:02 +0000 Original-Received: (at 35468) by debbugs.gnu.org; 5 May 2019 00:10:41 +0000 Original-Received: from localhost ([127.0.0.1]:52677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN4jp-0001Kw-2c for submit@debbugs.gnu.org; Sat, 04 May 2019 20:10:41 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:61090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN4jm-0001Kk-VB for 35468@debbugs.gnu.org; Sat, 04 May 2019 20:10:39 -0400 Original-Received: from weber.math.s.chiba-u.ac.jp (weber [192.168.32.4]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 2B5B7F08E7; Sun, 5 May 2019 09:10:38 +0900 (JST) (envelope-from mituharu@math.s.chiba-u.ac.jp) Original-Received: from 180.3.209.86 (SquirrelMail authenticated user mituharu) by weber.math.s.chiba-u.ac.jp with HTTP; Sun, 5 May 2019 09:10:38 +0900 In-Reply-To: <87pnoyj9wh.fsf@gmail.com> X-Priority: 3 (Normal) Importance: Normal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158770 Archived-At: >> And what does glyph_image_uses_mask hide? AFAIU, the current code >> simply looks at s->img->mask, and if so, why do we need an interface >> for that? > > I was thinking that since AFAIU the Cairo drawing doesn't set > s->img->mask it wouldn't make sense, from an interface POV, to check it > directly. I suppose it doesn't really matter in that case, and it would > be faster to just check s->img->mask even if the backend doesn't use it. IMO, image support for cairo is still premature and needs some restructuring. It does not support postprocessing (:conversion ALGORITHM), mask removal (:mask nil), or image-mask-p. Bitmaps for some image format are not stored in the premultiplied alpha format that cairo expects. All of them are supported in the Mac port and I set dummy s->img->mask there (not containing the actual mask bitmap data) if the image has an alpha channel. Probably setting a bitfield for the existence of mask (alpha channel) when creating image data would work as an alternative way. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp