From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#27230: eldoc doc Date: Thu, 14 Sep 2017 15:02:11 +0300 Message-ID: <1f39b877-4cbf-96d8-a318-7edf95f10406@yandex.ru> References: <282e174a-e9c0-6bec-32f5-ed9d772e5e1d@yandex.ru> <83efu8ta6n.fsf@gnu.org> <4107369a-5d50-7e46-2e81-57c4ef5c7965@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1505390603 26597 195.159.176.226 (14 Sep 2017 12:03:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Sep 2017 12:03:23 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 Cc: "Charles A. Roelli" , 27230@debbugs.gnu.org To: "Peder O. Klingenberg" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 14 14:03:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsSrP-0006hT-FL for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Sep 2017 14:03:11 +0200 Original-Received: from localhost ([::1]:47451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsSrW-0006Ae-QH for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Sep 2017 08:03:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsSrL-00068H-Px for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 08:03:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsSrG-0005By-7Z for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 08:03:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59404) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsSrG-0005B8-2x for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 08:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dsSrF-0006SB-Mz for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 08:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Sep 2017 12:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27230-submit@debbugs.gnu.org id=B27230.150539054324759 (code B ref 27230); Thu, 14 Sep 2017 12:03:01 +0000 Original-Received: (at 27230) by debbugs.gnu.org; 14 Sep 2017 12:02:23 +0000 Original-Received: from localhost ([127.0.0.1]:39850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsSqd-0006RH-9I for submit@debbugs.gnu.org; Thu, 14 Sep 2017 08:02:23 -0400 Original-Received: from mail-lf0-f51.google.com ([209.85.215.51]:43720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsSqb-0006R5-Pp for 27230@debbugs.gnu.org; Thu, 14 Sep 2017 08:02:22 -0400 Original-Received: by mail-lf0-f51.google.com with SMTP id c80so7527065lfh.0 for <27230@debbugs.gnu.org>; Thu, 14 Sep 2017 05:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uwvZc4rYp2q11RpErcyM4H8wBGWAems99Vx9BEaU11M=; b=tR8hu3nt1lQCGqCcCsCxKA+kdkj1n5/qArIypVpop4eAvlscTGBM/Rq2d1YZTorMRj bgSXXPaJFv/M/0yFwTt2ok2eXpTrfOjwjurzGmlZw6CXgvfNvq3gtZmaWyMQ7SBFKYRj mbPv0HBfY5CvP50xdWYPbwVnikgVCvAH8J5N3yvHtmRnklW0mDP/fVIpxuxe9KkSAAVQ mOnV4GnHdMUghVHCEkJcBZYHvoE9Hcx96M3cfxJbF4rwRAxW7BYerx1pZn/54wIssiqy TEjYDq2p8otD75bQzcW6wURN1LOrbwIoXHDD7SUSOl8apaR/lWyOluDSNUSBIEbE78oS hntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uwvZc4rYp2q11RpErcyM4H8wBGWAems99Vx9BEaU11M=; b=sqt6zqEEYeF6RkQD9zXYD9Ine9cp6EpvweGtuhX/0q1POpX7A1NmeiwO8qVy4V+5t+ 9hzkuKzvCI/4M5cWw8TX2HBrQLv9ihY1EvZrXZqy8IMRVr6fYaUla0IQxOtuR8VKVyOJ yxKjsett+U8D6gY7jw6/NWmmuRXheWzqTyIpNDGBq6FahH5/xykPetEbd4IEuHERBR7e coy3ijY3WbN5lzJ48Xl9516yEtQjQL0KrlkLMuM/5596fkMPHwNBWmZRqQQJtU4wCqp3 W06FlumEqbFeW5HRyMi8LdegEJKSOHom4FxmrtyLqVWOOFoQhnEsHTenaaQjHxHXap10 lipw== X-Gm-Message-State: AHPjjUjuOHLGNsyJupdwdjYF/w38epIje3clvgmVqSoi36MMOk+i13MB 6Sodg6kBWsgsvh+7gEQ= X-Google-Smtp-Source: AOwi7QA1kQRo3AybmJDOb478qm+R8nTb57rgpppco6zjMHWDu2KNrst79/nIV3ICsr5W+btZxYYXqg== X-Received: by 10.25.208.137 with SMTP id h131mr1180001lfg.101.1505390535482; Thu, 14 Sep 2017 05:02:15 -0700 (PDT) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id 72sm3470588lje.96.2017.09.14.05.02.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Sep 2017 05:02:13 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136956 Archived-At: On 9/14/17 2:47 PM, Peder O. Klingenberg wrote: > As I discovered today, when I updated my tree, there are callers outside > emacs core that do call eldoc-message with more than one argument. > slime-autodoc.el is one such package, which I use. Thanks for letting us know. > The slime project has an open issue on this, with a patch, but it hasn't > been applied yet, after sitting in the discussion for 17 days. I've commented on it: https://github.com/slime/slime/issues/400 For one thing, third-party packages should *not* use eldoc-message. > IMO commit 7ef0b5f611c2d56ac2edb8de287190f04c4b8f32 was an ill-advised > change. The code worked fine before, the cleanup afforded by breaking > the api was negligible. I think it should be reverted. Aside from breaking the "obviously wrong" callers like explained above, the code had a subtle bug where calling it with no format arguments, and then with some arguments, wouldn't update the message area. > (Slime would benefit from cleaing up their callers as well, no doubt, > but not every slime user should be forced to do that on their own. Of course, the project maintainers should do it. All the best, Dmitry.