From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sun, 11 Dec 2022 18:32:22 +0200 Message-ID: <1f3414b2-3150-789d-2340-ab928d0ee8b0@yandex.ru> References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> <83v8miv4x2.fsf@gnu.org> <83y1retdl3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18371"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59935@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 17:33:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4PGh-0004ZM-3x for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 17:33:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4PGD-0000AN-Pi; Sun, 11 Dec 2022 11:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4PGA-00009v-Vv for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 11:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4PGA-0002hc-Ma for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 11:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4PGA-0006Ji-5y for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 11:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167077635324268 (code B ref 59935); Sun, 11 Dec 2022 16:33:02 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 16:32:33 +0000 Original-Received: from localhost ([127.0.0.1]:46939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PFg-0006JM-SJ for submit@debbugs.gnu.org; Sun, 11 Dec 2022 11:32:33 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:36746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PFf-0006JE-Am for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 11:32:31 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so3232197wma.1 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 08:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=QE52h1Mrdwhh0LVOaTTLUbscExU8IV371EYRdMDr4Ow=; b=h06nyHZefiadDPuurPc0ruQORYKIXcc0s3rI9rvxYaXEnYk9BDyYnT3DM4tjiiCCgt zrIPVDIFlHFkHQ5R/ee4U40l0aV76f9Sp7JwYp+zwSDQgP1ji8jRBC6E2mA/bz9Zwq6s tZsZQYtN3Egn/NfbU1ABaQ01nSjJi1NFGfFdkfXf0Vp0gBrHdYoArzPgLp4qZ+qu58E0 D6ldQCUuhPizGuTnL7fq7AXHYAxzxF/TSFfDEltMndVYwELsiE2wJ3dgmgDow6Co3MZL xvnuoPHReX3hNVHbhV0mZICz8H4OghwLscA1de+xY4kHomNRbVtYgCa1FUfi96FdsEnc lkFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QE52h1Mrdwhh0LVOaTTLUbscExU8IV371EYRdMDr4Ow=; b=tGBJDT+Y2womN/4kLFljQirahqSqCGdrlyNGJ9E9nd6UMv4ACD0u+l4Np59ctGfHz/ +veHOQSsmCyB4pZCBy/oijugcEaNhJue2tHDkEJrbFnHEAb+NfmR0GIDuaPZLZrtV1bg lwHX5oJ/H1BImR15YxdhbU3lMP15fTvLQkQl5pQNcbm7ykAzTABR6q379w9zBt9mAoAn dtjYiYu9lDA6ImJ7p8he1Zc9WMuDTz7zA33GTkJcg2ywWp0oF7O5jPuh2Z8sEhDitnQw mH/Mi1TtfqVykxa2rb8L0+36oSnCKEjn71fFQ6MdGeaMCFqnjc5mmNknJgbQzsFEtth8 KlxQ== X-Gm-Message-State: ANoB5pnS7kMxvTWStokUzAQ5BdJFKCU6QJyCuPcXpXJ6QtWClBinbbN/ T0bR9fUWBmLokvfMBTcb6SA= X-Google-Smtp-Source: AA0mqf7pYhr7qHTwmeS4f9j6UslG7iMzVMN49xdMyEZnSJ7Q3xLgAcPGI8C/grqLSnmAtg6qVOeeBQ== X-Received: by 2002:a05:600c:a54:b0:3cf:a41d:844b with SMTP id c20-20020a05600c0a5400b003cfa41d844bmr10478574wmq.5.1670776344252; Sun, 11 Dec 2022 08:32:24 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m37-20020a05600c3b2500b003cfd4cf0761sm6973178wms.1.2022.12.11.08.32.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 08:32:23 -0800 (PST) Content-Language: en-US In-Reply-To: <83y1retdl3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250623 Archived-At: On 11/12/2022 12:54, Eli Zaretskii wrote: >> Date: Sun, 11 Dec 2022 12:23:13 +0200 >> Cc: 59935@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> >> The main problematic behavior (low performance) is exhibited by the >> "latest" branch, which looks like this: >> >> (let ((pr (project-current t))) >> (display-buffer >> (if (version< emacs-version "29.0.50") >> ;; ... >> (list-buffers-noselect >> arg nil (lambda (buf) (memq buf (project-buffers pr))))))) > > Yes, I see that. I still don't understand: this can easily be changed > to call project-buffers just once. Cue my very first response: If we just do that, pressing 'g' will only show the buffers that belonged to the project when project-list-buffers was called. And not necessarily the *current* list of project buffers. Though I guess there might be ways to avoid this, like creating a cache which will be invalidated in post-command-hook, something like that. >>> Anyway, I only entered this discussion because you asked about making >>> some non-trivial changes on the release branch. If that is no longer >>> an issue, I will gladly bow out of this. >> >> I expect Juri is going to argue for that later. For non-trivial changes >> in buff-menu.el, no less. > > I will wait for his comments, then. Let's.