all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "David Glasser" <glasser@davidglasser.net>
To: "Juri Linkov" <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] support filename prefixes and 100-character filenames in tar-mode.el
Date: Tue, 15 Apr 2008 16:17:27 -0700	[thread overview]
Message-ID: <1ea387f60804151617g5bb966b2t88232b96fada99a9@mail.gmail.com> (raw)
In-Reply-To: <87y77e28ux.fsf@jurta.org>

On Tue, Apr 15, 2008 at 3:35 PM, Juri Linkov <juri@jurta.org> wrote:
> >> > With all of the patch except for the change in the initial
>  >>  > initialization of name-end, the results look correct, except the
>  >>  > penultimate line ends in "foo2" instead of "foo20"; that is because
>  >>  > the name field here fill the entire field with no nulls, but the code
>  >>  > previously assumed there would be at least one null.  (It's possible
>  >>  > that similar adjustments are required for the initial values of
>  >>  > link-end, gname-end, and uname-end.)
>  >>
>  >>  Does your patch also handle @LongLink currently unsupported by tar-mode.el?
>  >
>  > Is it actually unsupported?  When I tried to make a tarball to test
>  > this issue with GNU tar, I saw stuff about "@LongLink" when I opened
>  > it in tar-mode.  (Try making a tarball from the one I sent using GNU
>  > tar; you'll see what I mean; I made my test tarball with pax, since
>  > that was what was used to make the one I opened when I first noticed
>  > this issue.)  I don't know if it was correct or not, though.
>
>  Please see a test tarball attached below.  It is correctly created with
>  GNU tar, but opening it in Emacs displays the following message:
>
>     Warning: premature EOF parsing tar file
>
>  Also its file listing is incomplete, file names are truncated, and content
>  of some files is inserted into the file listing in the tar-mode buffer.
>
>  I thought your patch will fix these problems.

Ugh, that's pretty gross.  Mine fixes issues with a different way of
encoding long file names, as far as I understand.  However, there is
*some* long-link support in tar-mode.el, just not whatever's up with
that file.

--dave


-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/




  reply	other threads:[~2008-04-15 23:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 17:51 [PATCH] support filename prefixes and 100-character filenames in tar-mode.el David Glasser
2008-04-13 22:23 ` Juri Linkov
2008-04-14  1:48   ` David Glasser
2008-04-15 22:35     ` Juri Linkov
2008-04-15 23:17       ` David Glasser [this message]
2008-04-16 23:17         ` Juri Linkov
2008-04-16 23:32           ` David Glasser
2008-04-17  9:21             ` Juri Linkov
2008-04-17 13:34               ` Chong Yidong
2008-04-22 20:51                 ` Juri Linkov
2008-04-22 21:20                   ` David Glasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ea387f60804151617g5bb966b2t88232b96fada99a9@mail.gmail.com \
    --to=glasser@davidglasser.net \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.