From: Jim Porter <jporterbugs@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: 66041@debbugs.gnu.org
Subject: bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'?
Date: Sun, 17 Sep 2023 14:54:36 -0700 [thread overview]
Message-ID: <1e19cc18-9942-aa51-c49e-9441e873f037@gmail.com> (raw)
In-Reply-To: <CALDnm53Y_dL3o+H8Kc5ukn4YPKK-=039LRyVy7FZDP_1q5rKJg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
On 9/17/2023 2:22 PM, João Távora wrote:
> On Sun, Sep 17, 2023 at 5:42 AM Jim Porter <jporterbugs@gmail.com> wrote:
>
>> Personally, I think it'd be better for the "echo" faces for Flymake
>> notes to just inherit from 'compilation-info'. They have almost
>> identical uses as far as I can tell, and then things would look more
>
> To better understand what you mean, can you post two screenshots -- with
> and without your proposed change -- of what the default theme would look
> like in a simple file with some Flymake overlays?
Sure, here are screenshots of Flymake under 29, 30, and 30 plus my
patch. In particular, pay close attention to the mode-line colors. It
took me a few seconds of close inspection to see the green underline for
the note counter in the mode-line.
> Also, a patch showing exactly the change you propose would be useful. And
> keep in mind one can define a face to inherit from two faces (AFAIK).
And here's also a patch. (Not for the renaming of note->info, but that's
straightforward enough to imagine, I hope.)
[-- Attachment #2: emacs-29.png --]
[-- Type: image/png, Size: 17034 bytes --]
[-- Attachment #3: emacs-30.png --]
[-- Type: image/png, Size: 20189 bytes --]
[-- Attachment #4: emacs-30-patched.png --]
[-- Type: image/png, Size: 20320 bytes --]
[-- Attachment #5: 0001-Use-compilation-info-as-the-basis-for-Flymake-note-f.patch --]
[-- Type: text/plain, Size: 1276 bytes --]
From 26c26763bed97f97fb795012c06cb91dfd28de5c Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Sun, 17 Sep 2023 14:50:22 -0700
Subject: [PATCH] Use 'compilation-info' as the basis for Flymake note faces
* lisp/progmodes/flymake.el (flymake-note-echo)
(flymake-note-echo-at-eol): Inherit from 'compilation-info'.
---
lisp/progmodes/flymake.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index b044a661911..66aff1d1fe9 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -442,7 +442,7 @@ flymake-warning-echo
:package-version '(Flymake . "1.3.4"))
(defface flymake-note-echo
- '((t :inherit flymake-note))
+ '((t :inherit compilation-info))
"Face used for showing summarized descriptions of notes."
:package-version '(Flymake . "1.3.4"))
@@ -463,7 +463,7 @@ flymake-warning-echo-at-eol
:package-version '(Flymake . "1.3.5"))
(defface flymake-note-echo-at-eol
- '((t :inherit (flymake-end-of-line-diagnostics-face flymake-note)))
+ '((t :inherit (flymake-end-of-line-diagnostics-face compilation-info)))
"Face like `flymake-note-echo', but for end-of-line overlays."
:package-version '(Flymake . "1.3.5"))
--
2.25.1
next prev parent reply other threads:[~2023-09-17 21:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 4:42 bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'? Jim Porter
2023-09-17 21:22 ` João Távora
2023-09-17 21:54 ` Jim Porter [this message]
2023-09-17 22:15 ` João Távora
2023-09-18 4:36 ` Jim Porter
2023-09-18 10:44 ` Eli Zaretskii
2023-09-18 10:46 ` João Távora
2023-09-18 11:42 ` Eli Zaretskii
2023-09-18 12:52 ` João Távora
2023-09-18 14:32 ` Eli Zaretskii
2023-09-18 15:31 ` João Távora
2023-09-18 17:29 ` Eli Zaretskii
2023-09-18 18:55 ` João Távora
2023-09-18 17:44 ` Jim Porter
2023-09-18 18:49 ` João Távora
2023-09-18 19:00 ` Jim Porter
2023-09-21 21:40 ` João Távora
2023-09-24 3:38 ` Jim Porter
2023-09-24 8:18 ` João Távora
2023-09-25 8:59 ` João Távora
2023-09-25 10:32 ` Eli Zaretskii
2023-09-25 11:46 ` João Távora
2023-09-25 12:08 ` Eli Zaretskii
2023-09-25 12:12 ` João Távora
2023-09-25 12:49 ` Eli Zaretskii
2023-09-25 13:52 ` João Távora
2023-09-25 14:19 ` Eli Zaretskii
2023-09-25 16:55 ` João Távora
2023-09-25 17:23 ` Eli Zaretskii
2023-09-25 18:23 ` João Távora
2023-09-25 20:55 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e19cc18-9942-aa51-c49e-9441e873f037@gmail.com \
--to=jporterbugs@gmail.com \
--cc=66041@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.