From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Wed, 2 Nov 2022 15:09:21 -0700 Message-ID: <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------MdGdMLhnpGeLoiJ7JGAOQlcC" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2725"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58909@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 23:10:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqLwH-0000Z0-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 23:10:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqLvy-0003U8-H2; Wed, 02 Nov 2022 18:10:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqLvw-0003Tz-F2 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 18:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqLvu-0006ry-P0 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 18:10:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqLvu-0005L8-9b for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 18:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166742697020482 (code B ref 58909); Wed, 02 Nov 2022 22:10:02 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 22:09:30 +0000 Original-Received: from localhost ([127.0.0.1]:47318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqLvO-0005KH-0n for submit@debbugs.gnu.org; Wed, 02 Nov 2022 18:09:30 -0400 Original-Received: from mail-pg1-f175.google.com ([209.85.215.175]:36428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqLvM-0005K3-B5 for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 18:09:28 -0400 Original-Received: by mail-pg1-f175.google.com with SMTP id s196so56730pgs.3 for <58909@debbugs.gnu.org>; Wed, 02 Nov 2022 15:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=rGF4ODj0ocSm/hbp196Vxx+0SnlRFaN7h4+yOd3ybQU=; b=hLCeAsEG60qUejnjuKftPUHKnOhS7XoFliibK18Kv4evjXufx4oe2sT4dlU7jqFDAA 5qLnEpDAIN+7jaIEK1qB8qZ118oZ0HAgZeBuVPnmuM4sH3o6lxkmjgtP7mQUElNnVkHb e6gFljRmjReW/Li7+X6jKR5Uq1IiryQL+NCf6n5/yO0eUtw4+TmdeCN+YDLxjSgiN4jf 1cl7Tozf0uuhWonl+RFuwTaTwpfG9KgN3gJ5e1NwQVnIDtoGQyYA2I+DOGpzQrSD5UGO ERERCUr0kwRU2FfGwAKq0FPpquQDDYBLeZ8Rp00nbaStsBK6l0VcuQ2Y/u+inerpglvr mE/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rGF4ODj0ocSm/hbp196Vxx+0SnlRFaN7h4+yOd3ybQU=; b=RBSYKz9uglruqTaNkF5IpKhJoiYLGC08SNKAMksXUgMUtirt/kDEv5zTkhqRx7ABVr 4a22YXGJ00nhAbeGqeuI0Pphv8p5h5TOKcFvgPCB+tBaMhXNrQShjyiuUM2UtX5UsmMh hzY0eF4ubii9uD0VyxO7s1sT1tb92umjzphyMzFDqBWdmEkFsjaWE2x0BNRn116qyZot z+zwDUrXyRsHHx4kZLtl60FbgSZrVQpPlCM1+Cs4VCN4/sbgJ1gl1aavtx2y/fe9+lK4 1pjRtNTzRGj3A2i2jYIkwicnQQajKjwzc/4IxCbv6oELAHZxC0peUGBtR7Lrnt70ztBa uAaw== X-Gm-Message-State: ACrzQf0sR8V2FnJ/huEroJSQk+0UMXlkzfkmO4AJL04SD94LxVCVIcqM +8jtDGFpZh2qPccJ9HGiwic= X-Google-Smtp-Source: AMsMyM4llpUw+Fr+l+xBEHiiKra3ET/VclyNemVZwwUCMqSi2YtK1hoUjo9udfRylN8YD4kQ+c5d1g== X-Received: by 2002:a05:6a00:1905:b0:566:2a02:e1a1 with SMTP id y5-20020a056a00190500b005662a02e1a1mr27538881pfi.1.1667426962208; Wed, 02 Nov 2022 15:09:22 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p66-20020a625b45000000b0053e38ac0ff4sm8957943pfb.115.2022.11.02.15.09.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 15:09:21 -0700 (PDT) Content-Language: en-US In-Reply-To: <83zgd986fi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246898 Archived-At: This is a multi-part message in MIME format. --------------MdGdMLhnpGeLoiJ7JGAOQlcC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/2022 1:09 PM, Eli Zaretskii wrote: >> 'server-delete-client' is called in a bunch of spots, so at minimum, I'd >> want to be extra-careful that prompting doesn't break one of those >> cases. > > Sorry, I meant server-handle-delete-frame. Oh, ok. That would be easy then. But since your preference was to just leave things as they are, let's not make this change. I can adjust things locally without it. >>>> If starting the server activates a minor mode, then Emacs can use a >>>> minor-mode keymap for server-mode. [snip] >>> >>> I'm fine with doing that, but we must also make sure this mode is >>> turned on when users invoke server-start interactively. >> >> I think that makes sense, and it should be fairly straightforward. I'll >> work on a patch for this. > > Thanks. Ok, here's a patch for that. It just sets the 'server-mode' variable (and 'global-minor-modes' to be polite) inside 'server-start'. It would probably be more elegant if we could make 'server-start' just call '(server-mode)' (instead of the other way around like it is now), but I think it would be hard to do that while staying 100% compatible. Does this seem ok? --------------MdGdMLhnpGeLoiJ7JGAOQlcC Content-Type: text/plain; charset=UTF-8; name="0001-Enable-disable-server-mode-when-starting-stopping-th.patch" Content-Disposition: attachment; filename*0="0001-Enable-disable-server-mode-when-starting-stopping-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA2ODdmMmFiNDgwM2M0MWY2YTMzMjgwMDQ4MjQzYjA5NjI4MTZkMmI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAwOToyMjo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEVuYWJsZS9kaXNhYmxlICdzZXJ2ZXItbW9kZScgd2hlbiBzdGFydGluZy9zdG9wcGlu ZyB0aGUKIHNlcnZlcgoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLW1vZGUta2V5bWFwKTog TmV3IGtleW1hcC4uLgooc2VydmVyLW1vZGUpOiAuLi4gdXNlIGl0Lgooc2VydmVyLXN0YXJ0 KTogVXBkYXRlIHRoZSAnc2VydmVyLW1vZGUnIHZhcmlhYmxlIChhbmQgc3luYyB0bwonZ2xv YmFsLW1pbm9yLW1vZGVzJykgd2hlbiBzdGFydGluZy9zdG9wcGluZyB0aGUgc2VydmVyLgot LS0KIGxpc3Avc2VydmVyLmVsIHwgMTIgKysrKysrKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Nl cnZlci5lbCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IDkwZDk3YzE1MzguLjE4NTQ4MTg2YjEg MTAwNjQ0Ci0tLSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC02 NzAsNyArNjcwLDYgQEAgc2VydmVyLXN0YXJ0CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIi90bXAvIikKICAgICAgICAgICAgICAgICAgKGlnbm9yZS1lcnJvcnMKICAgICAgICAg ICAgICAgICAgICAoZGVsZXRlLWRpcmVjdG9yeSAoZmlsZS1uYW1lLWRpcmVjdG9yeSBzZXJ2 ZXItZmlsZSkpKSkpKQotICAgICAgICAgKHNldHEgc2VydmVyLW1vZGUgbmlsKSA7OyBhbHJl YWR5IHNldCBieSB0aGUgbWlub3IgbW9kZSBjb2RlCiAgICAgICAgICAoZGlzcGxheS13YXJu aW5nCiAgICAgICAgICAgJ3NlcnZlcgogICAgICAgICAgIChjb25jYXQgIlVuYWJsZSB0byBz dGFydCB0aGUgRW1hY3Mgc2VydmVyLlxuIgpAQCAtNjg4LDcgKzY4Nyw5IEBAIHNlcnZlci1z dGFydAogICAgICAgKGlmIGxlYXZlLWRlYWQKIAkgIChwcm9nbgogCSAgICAodW5sZXNzIChl cSB0IGxlYXZlLWRlYWQpIChzZXJ2ZXItbG9nIChtZXNzYWdlICJTZXJ2ZXIgc3RvcHBlZCIp KSkKLQkgICAgKHNldHEgc2VydmVyLXByb2Nlc3MgbmlsKSkKKyAgICAgICAgICAgIChzZXRx IHNlcnZlci1tb2RlIG5pbAorICAgICAgICAgICAgICAgICAgZ2xvYmFsLW1pbm9yLW1vZGVz IChkZWxxICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlub3ItbW9kZXMpCisgICAgICAgICAgICAg ICAgICBzZXJ2ZXItcHJvY2VzcyBuaWwpKQogCTs7IE1ha2Ugc3VyZSB0aGVyZSBpcyBhIHNh ZmUgZGlyZWN0b3J5IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzb2NrZXQuCiAJKHNlcnZlci1l bnN1cmUtc2FmZS1kaXIgc2VydmVyLWRpcikKIAkod2hlbiBzZXJ2ZXItcHJvY2VzcwpAQCAt NzI4LDYgKzcyOSw4IEBAIHNlcnZlci1zdGFydAogCQkJICAgICAgIDpwbGlzdCAnKDphdXRo ZW50aWNhdGVkIHQpKSkpKQogCSAgKHVubGVzcyBzZXJ2ZXItcHJvY2VzcyAoZXJyb3IgIkNv dWxkIG5vdCBzdGFydCBzZXJ2ZXIgcHJvY2VzcyIpKQogCSAgKHByb2Nlc3MtcHV0IHNlcnZl ci1wcm9jZXNzIDpzZXJ2ZXItZmlsZSBzZXJ2ZXItZmlsZSkKKyAgICAgICAgICAoc2V0cSBz ZXJ2ZXItbW9kZSB0KQorICAgICAgICAgIChwdXNoICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlu b3ItbW9kZXMpCiAJICAod2hlbiBzZXJ2ZXItdXNlLXRjcAogCSAgICAobGV0ICgoYXV0aC1r ZXkgKHNlcnZlci1nZXQtYXV0aC1rZXkpKSkKIAkgICAgICAocHJvY2Vzcy1wdXQgc2VydmVy LXByb2Nlc3MgOmF1dGgta2V5IGF1dGgta2V5KQpAQCAtNzk2LDYgKzc5OSwxMCBAQCBzZXJ2 ZXItcnVubmluZy1wCiAJdCkKICAgICAoZmlsZS1lcnJvciBuaWwpKSkKIAorOzsgVGhpcyBr ZXltYXAgaXMgZW1wdHksIGJ1dCBhbGxvd3MgdXNlcnMgdG8gZGVmaW5lIGtleWJpbmRpbmdz IHRvIHVzZQorOzsgd2hlbiBgc2VydmVyLW1vZGUnIGlzIGFjdGl2ZS4KKyhkZWZ2YXIta2V5 bWFwIHNlcnZlci1tb2RlLWtleW1hcCkKKwogOzs7IyMjYXV0b2xvYWQKIChkZWZpbmUtbWlu b3ItbW9kZSBzZXJ2ZXItbW9kZQogICAiVG9nZ2xlIFNlcnZlciBtb2RlLgpAQCAtODA1LDYg KzgxMiw3IEBAIHNlcnZlci1tb2RlCiBgc2VydmVyLXN0YXJ0JyBmb3IgZGV0YWlscy4iCiAg IDpnbG9iYWwgdAogICA6dmVyc2lvbiAiMjIuMSIKKyAgOmtleW1hcCBzZXJ2ZXItbW9kZS1r ZXltYXAKICAgOzsgRml4bWU6IFNob3VsZCB0aGlzIGNoZWNrIGZvciBhbiBleGlzdGluZyBz ZXJ2ZXIgc29ja2V0IGFuZCBkbwogICA7OyBub3RoaW5nIGlmIHRoZXJlIGlzIG9uZSAoZm9y IG11bHRpcGxlIEVtYWNzIHNlc3Npb25zKT8KICAgKHNlcnZlci1zdGFydCAobm90IHNlcnZl ci1tb2RlKSkpCi0tIAoyLjI1LjEKCg== --------------MdGdMLhnpGeLoiJ7JGAOQlcC--