From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#24972: 26.0.50; Multibyte characters are misaligned in ibuffer Date: Tue, 22 Nov 2016 11:51:50 +0800 Message-ID: <1dbeb208-b7b5-e445-1946-c71aec1660da@gmail.com> References: <87bmxa2d2v.fsf@udel.edu> <39442582-6036-47de-1a7a-4d46e43496c1@gmail.com> <20161121093545.GA1654@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1479786794 20504 195.159.176.226 (22 Nov 2016 03:53:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 Nov 2016 03:53:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 Cc: 24972@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 22 04:53:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c928q-0004mA-LA for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 04:53:08 +0100 Original-Received: from localhost ([::1]:53086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c928u-0006Cz-4z for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 22:53:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c928n-0006Ce-M8 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 22:53:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c928k-0001Ld-DR for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 22:53:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c928k-0001LK-9G for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 22:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c928j-0007pa-TS for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 22:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2016 03:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24972 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24972-submit@debbugs.gnu.org id=B24972.147978672630031 (code B ref 24972); Tue, 22 Nov 2016 03:53:01 +0000 Original-Received: (at 24972) by debbugs.gnu.org; 22 Nov 2016 03:52:06 +0000 Original-Received: from localhost ([127.0.0.1]:37641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c927q-0007oJ-12 for submit@debbugs.gnu.org; Mon, 21 Nov 2016 22:52:06 -0500 Original-Received: from mail-pg0-f68.google.com ([74.125.83.68]:34186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c927o-0007no-Vp for 24972@debbugs.gnu.org; Mon, 21 Nov 2016 22:52:05 -0500 Original-Received: by mail-pg0-f68.google.com with SMTP id e9so705673pgc.1 for <24972@debbugs.gnu.org>; Mon, 21 Nov 2016 19:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=oYh/6DmFBvkutNd4/RntWMdjLvL8Jh8KJZOCenOpTIE=; b=ErPGwsdhsJSyEi9Cn/zOuOg+YsnBm0WkAPYcfVa1qsyw+xxZU/GsuLM40+Z+KjlZ39 PpT94lxgtgp1HjgOfvmdz1YOZ7kC1aNWZIk9rgq/lpTipTIhCh/rrUfhWuN5lRwvxBA9 BR3dTJIT6jeZjqsCYdHiw7VNRC5dTU7PrV8r2sj8io6iJ0UYATG4inuxlNNpXDWDvTY2 823q8m/FZdziyVnbJTHWe0tmh8MDFsBxTpmA9U5MqIqaxzitLJi2B4rnd13mNwmSP2Ng j25K6XoZ/GnZT/KwYIRBJGnvyrMRhspzh3HcBNMVyd6H/3RIVYVaTuZtZ/ItUWm2Vz1L 0Q0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=oYh/6DmFBvkutNd4/RntWMdjLvL8Jh8KJZOCenOpTIE=; b=VBiMSm4Xchz6DmgUGIzYzAyZ0uL4Ei8xmaiKQX7udCQtCfmpXpzqEXpvg/ZDjrb0yS xjEwtwRy+4kZOkYQSYMibzIdxFCQyMCBdATGea8zaXUfBpZsS9CwwmVVYyjsha21Bzl8 dNyedAxqcMPomm1g54OKHu1u1m0+cXWcWKNU3iEgB3d/kE8ChNk1RQ4rm9U/RhBBW5h0 42NsG/lFpDi06zk0qN4tOzOwLYNHI8YMpNDXV9IJezWghKy8b35CDaDm6vzj0ENkMyah TE1fNFZvH9c9yVUs8D/EDKCFlFKkmhmeUuHMESMwe6cdO0F3dVHyizokEVcn6YTvcK+i IFwQ== X-Gm-Message-State: AKaTC01blBBi3xB31RTF+8IZMtaK9MtyNdn9usfg+LGwv04worBnX36Z2vLS1C7aOfn2/w== X-Received: by 10.99.230.17 with SMTP id g17mr39645623pgh.82.1479786718677; Mon, 21 Nov 2016 19:51:58 -0800 (PST) Original-Received: from [0.0.0.0] ([188.166.240.79]) by smtp.gmail.com with ESMTPSA id b64sm40679235pfc.74.2016.11.21.19.51.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2016 19:51:58 -0800 (PST) In-Reply-To: <20161121093545.GA1654@holos.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125972 Archived-At: 在 2016年11月21日 17:35, Mark Oteiza 写道: > On 21/11/16 at 02:00pm, Liu Hui wrote: >> 在 2016年11月21日 02:58, Mark Oteiza 写道: >>> Liu Hui writes: >>>> As shown in the screenshot attached, multibyte characters (the second >>>> line) are misaligned in ibuffer. The problem seems at least relevant >>>> to the function `ibuffer-compile-format', which uses `length' rather >>>> than `string-width' for characters. >>> >>> Indeed, changing to string-width improves it. ibuffer should probably >>> also be using display properties to align the columns, but that's >>> another issue. >>> >>> Committed in 7e2a8b1. Thanks for reporting >> >> Thank you, but I find it does not work when the multibyte string is long. >> For example, if the string-width of buffer name, e.g. >> "一个很长很长的文件名", exceeds the default width of ibuffer column, M-x >> ibuffer will fail and issue an error. >> >> According to the backtrace, it is because `ibuffer-compile-format' calls >> `ibuffer-compile-make-substring-form'/`ibuffer-compile-make-eliding-form', >> which use `substring' to truncate the multibyte string. A similar issue was >> reported in https://github.com/emacs-helm/helm/issues/170. Probably >> replacing `substring' solves the problem. > > Ah, thanks. I pushed another change that fixes the error. Still, if the > name is a particular mix of half- and full-width though (e.g. > "aーーーーーー"), the next column(s) might be off by one. > Thank you, but the trailing "..." is missing for long buffer names, no matter whether they contain multibyte characters. For example, "01234567890123456789" becomes "012345678901234567". The normal result should be "012345678901234...".