From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program Date: Mon, 30 Oct 2023 00:14:48 +0200 Message-ID: <1d4683d3-197f-567e-043d-cb66eb67a95a@gutov.dev> References: <83wmv6arnv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8432"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 66806@debbugs.gnu.org To: Eli Zaretskii , Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 23:16:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qxE52-0001zi-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 23:16:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxE4N-0002B3-TL; Sun, 29 Oct 2023 18:15:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxE4A-00028Q-46 for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 18:15:30 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxE49-0001uK-Rw for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 18:15:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxE4g-0005t9-KM for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 18:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66806-submit@debbugs.gnu.org id=B66806.169861773122546 (code B ref 66806); Sun, 29 Oct 2023 22:16:02 +0000 Original-Received: (at 66806) by debbugs.gnu.org; 29 Oct 2023 22:15:31 +0000 Original-Received: from localhost ([127.0.0.1]:43973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxE4A-0005ra-Lr for submit@debbugs.gnu.org; Sun, 29 Oct 2023 18:15:31 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxE49-0005rN-6e for 66806@debbugs.gnu.org; Sun, 29 Oct 2023 18:15:30 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2DB045C00FF; Sun, 29 Oct 2023 18:14:51 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 29 Oct 2023 18:14:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698617691; x=1698704091; bh=U7zg5eAa4LTRxIP2OjTQgdGhKza7ZNlU0gT 0M37ylbw=; b=gln9laRo2z8NTjCOSIvCQ7C5E6JCYcHHmLe5EShm9arJpox7al4 GRiRUnApM6P3aI9TGW9Kdz2t3ZOzdgYzFDa8RoQMoefFkElI1FsR4IOrF66dq0yK P++HUiQhwGH9ho/6WK0qZXxbfv+NxelfoWP8HxpMPS5/2hIbncBEjtR6JMrMX27T 5v/gPgvRxRBDAGVu/cI9SvtsQd9taHkepN8MK61z2+YmgRXgHV2jxq1ZnUZgrPaH +6xJLXk2n/uYEam1xLagANTQ/FNt819TF6tCe8S7a40FUqV6yT0G2KHeRBuWv8pf N9xg/VTM7I0UweJxjGmtZ1BXFqYL1WbdFUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698617691; x=1698704091; bh=U7zg5eAa4LTRxIP2OjTQgdGhKza7ZNlU0gT 0M37ylbw=; b=eyYnjr8HCT3MLGpooroQm8m0gQg2EjO0IYKBiSyEKTDHwrQAgUv JWZ5DG5sy2JY4ZBd7CF+WMgixBT5gOsI73WOgj+S1ppJxwCYDbOz95HeSPmw9EHt eKbAudmc4d6nKaOGM6kH9GCdF1Gd6Yq76wBBgSC9McIBtQFqHgBxW8Xc1n2bsGg3 GW9gscsAyjwhTkItR8mi78iG5E5fxDr8dPjkJH/N7FhDK802e+FMuFMXIifpmfQW 5jcW2EoSfT4m1I82V5os4bZxFam/K3jGRFvxSWeaz4F0D53nl2Cmz1gHv1q9oe7f NlGLqD/wBL8aG9IQmcu/1Py4WhSEbAwSc7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrleekgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 29 Oct 2023 18:14:49 -0400 (EDT) Content-Language: en-US In-Reply-To: <83wmv6arnv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273534 Archived-At: On 29/10/2023 08:06, Eli Zaretskii wrote: >> Cc:dmitry@gutov.dev >> Date: Sat, 28 Oct 2023 22:36:07 -0700 >> From: Jim Porter >> >> --- a/lisp/progmodes/project.el >> +++ b/lisp/progmodes/project.el >> @@ -960,7 +960,8 @@ project-find-regexp >> (default-directory (project-root pr)) >> (files >> (if (not current-prefix-arg) >> - (project-files pr) >> + ;; XXX: See the comment in project-query-replace-regexp. >> + (cl-delete-if-not #'file-regular-p (project-files pr)) > ^^^^^^^^^^^^^^^^ > I think we want to prefer using seq.el functions, since seq.el is > nowadays preloaded. Is there a good reason to use cl-delete-if-not > here? I'm okay with using seq with other things equal, but in this case both cl- approaches are too slow, and seq-difference is no better because of consing and indirection overhead (about 10-20% slower than current). I'd say it's a shortcoming of seq.el: only having non-destructive versions. I had some hope for cl-nset-difference, but looking at the implementation it just delegates to the non-destructive cousin (I guess providing the optimized implementation was left as TODO).