From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>, Jim Porter <jporterbugs@gmail.com>
Cc: 66806@debbugs.gnu.org
Subject: bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program
Date: Mon, 30 Oct 2023 00:14:48 +0200 [thread overview]
Message-ID: <1d4683d3-197f-567e-043d-cb66eb67a95a@gutov.dev> (raw)
In-Reply-To: <83wmv6arnv.fsf@gnu.org>
On 29/10/2023 08:06, Eli Zaretskii wrote:
>> Cc:dmitry@gutov.dev
>> Date: Sat, 28 Oct 2023 22:36:07 -0700
>> From: Jim Porter<jporterbugs@gmail.com>
>>
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -960,7 +960,8 @@ project-find-regexp
>> (default-directory (project-root pr))
>> (files
>> (if (not current-prefix-arg)
>> - (project-files pr)
>> + ;; XXX: See the comment in project-query-replace-regexp.
>> + (cl-delete-if-not #'file-regular-p (project-files pr))
> ^^^^^^^^^^^^^^^^
> I think we want to prefer using seq.el functions, since seq.el is
> nowadays preloaded. Is there a good reason to use cl-delete-if-not
> here?
I'm okay with using seq with other things equal, but in this case both
cl- approaches are too slow, and seq-difference is no better because of
consing and indirection overhead (about 10-20% slower than current). I'd
say it's a shortcoming of seq.el: only having non-destructive versions.
I had some hope for cl-nset-difference, but looking at the
implementation it just delegates to the non-destructive cousin (I guess
providing the optimized implementation was left as TODO).
next prev parent reply other threads:[~2023-10-29 22:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 5:36 bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program Jim Porter
2023-10-29 6:06 ` Eli Zaretskii
2023-10-29 17:54 ` Jim Porter
2023-10-29 19:22 ` Eli Zaretskii
2023-10-29 22:14 ` Dmitry Gutov [this message]
2023-10-29 21:41 ` Dmitry Gutov
2023-10-30 0:58 ` Jim Porter
2023-10-30 2:00 ` Dmitry Gutov
2023-10-30 3:53 ` Jim Porter
2023-10-29 22:02 ` Dmitry Gutov
2023-10-30 0:25 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4683d3-197f-567e-043d-cb66eb67a95a@gutov.dev \
--to=dmitry@gutov.dev \
--cc=66806@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.