From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: lars <lars@nocrew.org>, 40562@debbugs.gnu.org
Subject: bug#40562: [patch] Treat records as arrays in ert object comparisons and add support for cl-structs
Date: Sat, 25 Apr 2020 17:27:53 -0400 [thread overview]
Message-ID: <1d3af678-6fa3-62ba-5d6b-b85bc182608e@gmail.com> (raw)
In-Reply-To: <275aa2c2-ec39-1d52-1a48-1d990949fdb5@gmail.com>
On 12/04/2020 11.50, Clément Pit-Claudel wrote:
> On 12/04/2020 05.24, Štěpán Němec wrote:
>> On Sat, 11 Apr 2020 23:06:47 -0400
>> Clément Pit-Claudel wrote:
>>
>>> On 11/04/2020 19.26, Štěpán Němec wrote:
>>>> This is incorrect, as witnessed by your very example (`c' instead of
>>>> `b'). Records are accessible with `aref', but the first slot is the type
>>>> descriptor, so you're making an off-by-one error here.
>>>
>>> Of course, it should be `for slot in (cl-struct-slot-info (type-of
>>> a))` not `for slot in (cdr (cl-struct-slot-info (type-of a)))`.
>>> Updated patch attached.
>>
>> Hm, except now you're duplicating the (eq (type-of a) (type-of b))
>> check.
>
> Yup; I don't think that's a problem :)
Is there anything else I should do before pushing this patch?
next prev parent reply other threads:[~2020-04-25 21:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 20:34 bug#40562: [patch] Treat records as arrays in ert object comparisons and add support for cl-structs Clément Pit-Claudel
2020-04-11 23:26 ` Štěpán Němec
2020-04-12 3:06 ` Clément Pit-Claudel
2020-04-12 9:24 ` Štěpán Němec
2020-04-12 15:50 ` Clément Pit-Claudel
2020-04-25 21:27 ` Clément Pit-Claudel [this message]
2020-08-08 13:02 ` Lars Ingebrigtsen
2020-08-18 14:07 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3af678-6fa3-62ba-5d6b-b85bc182608e@gmail.com \
--to=cpitclaudel@gmail.com \
--cc=40562@debbugs.gnu.org \
--cc=lars@nocrew.org \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.