From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 27 Oct 2022 17:21:24 +0300 Message-ID: <1cce089a-546e-7f13-0907-3d36452aef10@yandex.ru> References: <8735budxiz.fsf@gmail.com> <83a662dvgo.fsf@gnu.org> <871qqvj6qb.fsf@gmail.com> <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> <837d0lmmpi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20095"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: arstoffel@gmail.com, 58447@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 16:24:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo3ny-0004zA-4i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 16:24:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo3lk-0006ge-36; Thu, 27 Oct 2022 10:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo3li-0006bj-2B for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 10:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo3lh-0000FK-P9 for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 10:22:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo3lh-0004i8-KA for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 10:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.166688049618073 (code B ref 58447); Thu, 27 Oct 2022 14:22:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 27 Oct 2022 14:21:36 +0000 Original-Received: from localhost ([127.0.0.1]:58813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo3lH-0004hR-KD for submit@debbugs.gnu.org; Thu, 27 Oct 2022 10:21:35 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:38493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo3lF-0004hD-GU for 58447@debbugs.gnu.org; Thu, 27 Oct 2022 10:21:34 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id r186-20020a1c44c3000000b003cf4d389c41so1549847wma.3 for <58447@debbugs.gnu.org>; Thu, 27 Oct 2022 07:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=83Zc/eml6/RcnuIUxy3kHvqS4YZgRgHzQ6ed0y6zptg=; b=VERgDu+cZ1WDGXcFz8bzgGpjSJf9jC50WKPRGz3uH4xiSFam46E++48/x390yO8Ifq ITnTEJJ3RyAA9+Qv74pwiEXAgSVVYL1HJkyKhhR0w0nwJrIxDYnKWmCN9QqWPhM6K9k4 cRbP3oNs2ccQ6B2M5nnIdrvHecR7Ip6nbb5DIpCObc/sBqwASmP/wJzn96TKwC33UyU5 rQ9aT5EoGaVfD72mWzAL9bfPG+1VcsOglezvEaRSNNK0cHPFtOfVmlrzHFiJEILZgN6R IwF7QQWcbreSx6zABRnm70C9th9UxCl5JWtykwA9cVA+OpvN9O2vkwFFe1TFI5AHgaZE n4qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=83Zc/eml6/RcnuIUxy3kHvqS4YZgRgHzQ6ed0y6zptg=; b=Itnm6yA/qZMpQ1zPZfC4cOw5te5KiT6xJnTnKt7owSjSRyaTNDuu7Wo6u61IlK1JHr CDjk9ZA8sLw3uGI2H3fuWLOMmGDKmD1wMrysx2QA6lspZTLiLRW476Yc2iplC3G1ZZI3 K7S+JqwUR1KcjfOOlxvgBB/sG5gBgNKCN4ELXhSulUOzOtbj/bRbEq7TKjekbhR5OjFp vBoahJhEjPzbTwtCwyu+TuUkr+M8LsAZ9RaEXWvkU6Hf3aFvRwemda8cklaXQpJ7+Hsx DUpBwZgLRwNbqP0ble6tnehWBJf6yW3J2GTSmldBDzZRE+9YDHf/hko0DcRkNWs1vmn+ tGaQ== X-Gm-Message-State: ACrzQf0LsSDnoc4i6xYzN8Rre/QbxPhQHiSAh4ZpNwetjNxhON3IZQT8 xvU+pGWDM/+iXhYcW3PWhNI= X-Google-Smtp-Source: AMsMyM6Fp/BClPF9cIDz/PNspybELAKBHiPn+AjJxtH6PKKzMg3z1cy4tlaRzNq9BQkFjKVsou04FA== X-Received: by 2002:a1c:f30d:0:b0:3c3:7c80:67f4 with SMTP id q13-20020a1cf30d000000b003c37c8067f4mr6074023wmq.86.1666880487417; Thu, 27 Oct 2022 07:21:27 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id a12-20020a5d4d4c000000b0022e55f40bc7sm1237712wru.82.2022.10.27.07.21.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 07:21:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <837d0lmmpi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246305 Archived-At: On 27.10.2022 16:15, Eli Zaretskii wrote: >> Date: Thu, 27 Oct 2022 11:44:09 +0300 >> Cc:58447@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 26.10.2022 12:04, Augusto Stoffel wrote: >>> I'm copying Dmitry. >> Hi! >> >>> On Tue, 11 Oct 2022 at 22:13, Eli Zaretskii wrote: >>> >>>>> From: Augusto Stoffel >>>>> Date: Tue, 11 Oct 2022 20:29:24 +0200 >>>>> >>>>> `project-find-file' and related commands share their history with more >>>>> general commands like `find-file', so they should add the absolute file >>>>> name to history. Currently, file names relative to the project root are >>>>> added. The attached patch fixes this. >>>> Shouldn't project.el have its separate history of file names, >>> I'm not sure that's useful, but then the history items should be >>> absolute file names anyway. >>> >>>> perhaps even a project-specific history? >>> This might make sense. >> I like both of these ideas, except I'm not sure how to implement the >> project-specific part better. >> >> I suppose we won't be passing the history var to completing-read anymore? > I thought about a project-specific history variable. ...one global variable per project?