From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: hokomo Newsgroups: gmane.emacs.bugs Subject: bug#56241: [PATCH] icalendar doesn't correctly process arbitrary diary sexp entries Date: Wed, 6 Jul 2022 20:58:23 +0200 Message-ID: <1cbe531a-8ffd-29ae-42fe-fb1207079aa5@airmail.cc> References: <21bff87f-b8dc-c7bc-41ab-97c7077a0535@airmail.cc> <87edza8rbu.fsf@gnus.org> <87mtdxt4mr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23504"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Cc: Ulf Jasper , 56241@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 23:12:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9CJp-0005sP-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 23:12:21 +0200 Original-Received: from localhost ([::1]:58666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9CJn-00062U-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 17:12:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9BQN-0004hX-U3 for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 16:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9BQN-00072e-Jz for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 16:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9BQN-0003SL-Ec for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 16:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: hokomo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 20:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56241-submit@debbugs.gnu.org id=B56241.165713848413202 (code B ref 56241); Wed, 06 Jul 2022 20:15:03 +0000 Original-Received: (at 56241) by debbugs.gnu.org; 6 Jul 2022 20:14:44 +0000 Original-Received: from localhost ([127.0.0.1]:55241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9BQ4-0003Qr-5y for submit@debbugs.gnu.org; Wed, 06 Jul 2022 16:14:44 -0400 Original-Received: from [37.120.193.124] (port=39464 helo=mail.cock.li) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9AEK-0001G9-EQ for 56241@debbugs.gnu.org; Wed, 06 Jul 2022 14:58:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=airmail.cc; s=mail; t=1657133905; bh=hmweBYOwzaZUgLN8fObr3lPmPmq4y3rynJwGsgo3s10=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=g7hNB09NH6lcWaq9WOSH6sVB9Jguu2hrVQT1EdJW5MS5TVts9p+X+yDuHR4JTTEXM O4F97GD3vA8A8WbFfW8fDSvQOqnAeosfepo/PWOqKcd1DieOPDceU7sLgvcYDyEYS7 M6kt9JN6RDAOULB/BaSqy/KztZ1qTaOzTmkHxBmDy5sb6zo88ubighKxlj3C1OTkz2 dkCNkuXEu+dMkPo39lZKPNp6R9A6JrNFjXdB+T5SCP0G183vObUdVFQN1f/ilWKunM 4ni2HV6Vxx7ubPwet5WhPTWrg1Ll95yQNDKMYqmJqwS8rH3VFTXywZjWwfPoQZcYU/ gj4Gmgweob/1Q== Content-Language: en-US In-Reply-To: <87mtdxt4mr.fsf@gnus.org> X-Mailman-Approved-At: Wed, 06 Jul 2022 16:14:43 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236299 Archived-At: > Right; I can reproduce that problem. I've added Ulf to the CCs; perhaps > he has some comments. It's been a week since then. Any ideas on how to move forward or should we give it more time? :-) To summarize, the problems are: (1) A diary sexp not generating any events for the configured number of enumeration days is treated effectively as a parsing failure, meaning that the next type of diary entry is tried instead of just not producing any events. (2) Improper parsing of diary sexps (using regexes instead of e.g. `read') leads to diary sexps not being able to span multiple lines or have more than a single closing parenthesis (i.e. any sort of nested expression). (3) Not strictly in the scope of icalendar itself, but still related the handling of diary sexps: Org's parser seems to assume that each diary sexp is on a single line. This and the two limitations above end up propagating to ox-icalendar. hokomo