From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: wkirschbaum@gmail.com, gregory@heytings.org, casouri@gmail.com,
62333@debbugs.gnu.org
Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes
Date: Fri, 31 Mar 2023 04:10:54 +0300 [thread overview]
Message-ID: <1c4c8b47-e4aa-242a-bb66-1d6b5c879de4@yandex.ru> (raw)
In-Reply-To: <83lejf7r2o.fsf@gnu.org>
On 29/03/2023 14:08, Eli Zaretskii wrote:
>> Date: Wed, 29 Mar 2023 00:08:53 +0300
>> Cc: wkirschbaum@gmail.com, gregory@heytings.org, casouri@gmail.com,
>> 62333@debbugs.gnu.org
>> From: Dmitry Gutov <dgutov@yandex.ru>
>>
>>>> Is that because we don't think the user level narrowing is done purely
>>>> for visual effect?
>>>
>>> Indeed, it isn't always for visual effect.
>>
>> When isn't it? Is there a way to determine that from code?
>
> I'm not sure I understand the question, but if I do, then narrowing to
> prevent search functions
If we're talking about isearch, then that seems like a natural
consequence of visual effect (hiding the remainder of the buffer): even
if isearch highlighted those other hits, they would not be visible.
> and commands from finding irrelevant hits is
> one example that comes to mind.
More or less the same, except we have the user option
widen-automatically, which apparently (?) allows any command to "widen
when they want to"?
Used by popular demand in e.g. xref--goto-char. And IIUC 'find-tag' just
always calls 'widen' irrespective of this variable's value.
>>>> judging by regular user requests for make this or that command
>>>> ignore user-level narrowing, it seems like "purely visual" should be the
>>>> default interpretation.
>>>
>>> I think you base your judgment on feedback from users who are not used
>>> to take advantage of narrowing in editing. I think most young people
>>> aren't, since this feature is more-or-less unique to Emacs.
>>
>> Either narrowing should be used to change lexical/grammatical/etc
>> context, or it should not. Do we have any documentation that says one or
>> the other way? That should affect how Lisp code deals with narrowing --
>> which interactive functions should widen, and so on.
>
> I was talking about user commands that narrow, so I'm not sure I
> understand how documentation could help. When the user types "C-x n n",
> there's nothing Emacs can do except obey.
There is really only one main user command that narrows, and that's
narrow-to-region, bound to 'C-x n n'.
But none of that describes how other Emacs features should react to it.
Simple example: if the beginning of the narrowed region falls inside a
(let's say multine) string, should the visible remainder of that string
continue to be highlighted as a string? Or should the buffer contents
after the string's closer now be highlighted as being inside a string?
next prev parent reply other threads:[~2023-03-31 1:10 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 14:00 bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Wilhelm Kirschbaum
2023-03-23 1:03 ` Dmitry Gutov
2023-03-23 3:03 ` Yuan Fu
2023-03-23 4:20 ` Dmitry Gutov
2023-03-23 7:13 ` Eli Zaretskii
2023-03-23 21:18 ` Yuan Fu
2023-03-23 21:30 ` Dmitry Gutov
2023-03-23 22:06 ` Dmitry Gutov
2023-03-23 23:59 ` Yuan Fu
2023-03-24 6:05 ` Eli Zaretskii
2023-03-24 7:34 ` Yuan Fu
2023-03-25 1:51 ` Dmitry Gutov
2023-03-25 12:34 ` Eli Zaretskii
2023-03-25 13:00 ` Dmitry Gutov
2023-03-25 13:14 ` Eli Zaretskii
2023-03-25 13:44 ` Dmitry Gutov
2023-03-25 14:09 ` Eli Zaretskii
2023-03-25 14:18 ` Dmitry Gutov
2023-03-25 14:41 ` Eli Zaretskii
2023-03-25 15:25 ` Dmitry Gutov
2023-03-25 15:57 ` Eli Zaretskii
2023-03-25 16:03 ` Dmitry Gutov
2023-03-25 16:24 ` Eli Zaretskii
2023-03-25 17:05 ` Dmitry Gutov
2023-03-25 17:40 ` Eli Zaretskii
2023-03-25 19:31 ` Yuan Fu
2023-03-25 23:29 ` Dmitry Gutov
2023-03-26 22:52 ` Yuan Fu
2023-03-27 1:29 ` Dmitry Gutov
2023-03-26 4:28 ` Eli Zaretskii
2023-03-26 22:57 ` Yuan Fu
2023-03-27 13:32 ` Eli Zaretskii
2023-03-27 18:43 ` Yuan Fu
2023-03-25 22:57 ` Dmitry Gutov
2023-03-26 5:04 ` Eli Zaretskii
2023-03-26 9:25 ` Dmitry Gutov
2023-03-26 10:01 ` Eli Zaretskii
2023-03-26 22:00 ` Dmitry Gutov
2023-03-27 8:24 ` Gregory Heytings
2023-03-27 13:39 ` Eli Zaretskii
2023-03-27 20:05 ` Gregory Heytings
2023-03-28 11:30 ` Eli Zaretskii
2023-03-28 11:39 ` Gregory Heytings
2023-03-28 12:11 ` Eli Zaretskii
2023-03-28 12:25 ` Gregory Heytings
2023-03-28 12:36 ` Eli Zaretskii
2023-03-27 23:06 ` Dmitry Gutov
2023-03-28 11:32 ` Eli Zaretskii
2023-03-28 21:08 ` Dmitry Gutov
2023-03-29 11:08 ` Eli Zaretskii
2023-03-31 1:10 ` Dmitry Gutov [this message]
2023-03-31 1:27 ` Dmitry Gutov
2023-03-31 6:19 ` Eli Zaretskii
2023-03-31 7:46 ` Eli Zaretskii
2023-03-31 12:38 ` Dmitry Gutov
2023-03-31 13:03 ` Eli Zaretskii
2023-03-31 13:26 ` Dmitry Gutov
2023-03-31 12:46 ` Dmitry Gutov
2023-03-31 13:06 ` Eli Zaretskii
2023-03-31 18:43 ` Yuan Fu
2023-04-01 1:53 ` Dmitry Gutov
2023-04-01 5:47 ` Eli Zaretskii
2023-04-01 16:12 ` Dmitry Gutov
2023-04-02 22:08 ` Yuan Fu
2023-04-03 12:31 ` Eli Zaretskii
2023-03-27 23:20 ` Dmitry Gutov
2023-03-27 13:29 ` Eli Zaretskii
2023-03-27 23:33 ` Dmitry Gutov
2023-03-28 11:38 ` Eli Zaretskii
2023-03-28 21:19 ` Dmitry Gutov
2023-03-29 11:17 ` Eli Zaretskii
2023-03-30 15:50 ` Gregory Heytings
2023-03-30 16:04 ` Eli Zaretskii
2023-03-30 16:28 ` Gregory Heytings
2023-03-30 16:40 ` Eli Zaretskii
2023-03-30 17:27 ` Gregory Heytings
2023-03-30 17:47 ` Eli Zaretskii
2023-03-30 20:14 ` Gregory Heytings
2023-03-30 22:08 ` Gregory Heytings
2023-03-31 6:15 ` Eli Zaretskii
2023-03-31 1:25 ` Dmitry Gutov
2023-03-31 6:22 ` Eli Zaretskii
2023-03-31 1:17 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c4c8b47-e4aa-242a-bb66-1d6b5c879de4@yandex.ru \
--to=dgutov@yandex.ru \
--cc=62333@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.