From: Dmitry Gutov <dmitry@gutov.dev>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>,
Eli Zaretskii <eliz@gnu.org>
Cc: 63949@debbugs.gnu.org
Subject: bug#63949: 30.0.50; `vc-print-log´ does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs
Date: Sun, 18 Jun 2023 05:42:44 +0300 [thread overview]
Message-ID: <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> (raw)
In-Reply-To: <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de>
On 16/06/2023 22:33, Jens Schmidt wrote:
> On 2023-06-10 19:23, Eli Zaretskii wrote:
>
>> I'd also like to hear Dmitry's views on these issues. He was until
>> now silent in this discussion, AFAICT.
>
> @Dmitry: What's your view on these issues? Just making the handling of
> VC parent buffer more documented and "more consistent", whatever that
> means, or do you prefer some particular direction?
I think the appropriate thing here is to back out of the change that
caused the regression (d494833d47968fcd97ba549654a259d6fb6c2eee, as
we've found out) and then try to re-fix it some other way (in master?).
Or maybe adjust the current code such as when vc-deduce-fileset-1 does
change the current buffer, vc-deduce-fileset retains that change.
For example, using this ugly-ish (100% untested) patch:
diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 91d3f6f70d3..91aae40a677 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -1121,10 +1121,13 @@ vc-deduce-fileset
the returned list.
BEWARE: this function may change the current buffer."
- (with-current-buffer (or (buffer-base-buffer) (current-buffer))
- (vc-deduce-fileset-1 not-state-changing
- allow-unregistered
- state-model-only-files)))
+ (let (new-buf)
+ (with-current-buffer (or (buffer-base-buffer) (current-buffer))
+ (vc-deduce-fileset-1 not-state-changing
+ allow-unregistered
+ state-model-only-files)
+ (setq new-buf (current-buffer)))
+ (set-buffer new-buf)))
(defun vc-deduce-fileset-1 (not-state-changing
allow-unregistered
The fact that some backends do call vc-setup-buffer inside
vc-xx-print-log and some dont', also bears investigation. But the
question I would like to have answered is, can we drop this call from
all of them? Rather than trying to add it everywhere.
next prev parent reply other threads:[~2023-06-18 2:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 21:04 bug#63949: 30.0.50; `vc-print-log´ does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-08 13:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-08 20:21 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-08 21:33 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-08 22:10 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 6:09 ` Eli Zaretskii
2023-06-09 20:27 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10 6:01 ` Eli Zaretskii
2023-06-10 15:44 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10 15:55 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10 17:23 ` Eli Zaretskii
2023-06-10 21:18 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-11 5:06 ` Eli Zaretskii
2023-06-16 19:33 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-17 3:15 ` Dmitry Gutov
2023-06-18 2:42 ` Dmitry Gutov [this message]
2023-06-18 5:35 ` Eli Zaretskii
2023-06-18 9:11 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-18 12:00 ` Dmitry Gutov
[not found] ` <e695eaa4-2f39-1b20-1cd4-fe7fdaeb3d61@vodafonemail.de>
2023-06-20 2:41 ` Dmitry Gutov
2023-06-21 13:03 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-21 14:37 ` Dmitry Gutov
2023-06-21 15:30 ` Eli Zaretskii
2023-06-24 3:08 ` Dmitry Gutov
2023-06-26 19:54 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-29 21:37 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-30 5:57 ` Eli Zaretskii
2023-07-17 19:53 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-18 0:55 ` Dmitry Gutov
2023-07-18 11:08 ` Eli Zaretskii
2023-06-08 22:44 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 6:41 ` Eli Zaretskii
2023-06-09 18:44 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-08 23:09 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev \
--to=dmitry@gutov.dev \
--cc=63949@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.