all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Colin Williams <lackita@gmail.com>
To: emacs-devel@gnu.org
Subject: Bug fix for eshell-remote-command in lisp/eshell/esh-ext.el
Date: Mon, 27 Jul 2009 00:17:44 -0400	[thread overview]
Message-ID: <1b97198a0907262117x3440464dv1c513b18f5cfa75@mail.gmail.com> (raw)

The function shell-command will sometimes split the current frame to
display the output.  This means that even though eshell-remote-command
kills the buffer in question, the window layout has been altered.  I
suggest changing

	  (setq exitcode
	           (funcall handler 'shell-command
			       (mapconcat 'shell-quote-argument
				                 (append (list command) args) " ")
		   outbuf errbuf))

to

	  (setq exitcode
		(save-window-excursion
		  (funcall handler 'shell-command
			   (mapconcat 'shell-quote-argument
				      (append (list command) args) " ")
			   outbuf errbuf)))

which will fix any mucking around with the frames window configuration
that shell-command decides to do.

This is my first bug fix for a gnu project, so if you need me to
provide a diff for this change, let me know.

Colin




             reply	other threads:[~2009-07-27  4:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27  4:17 Colin Williams [this message]
2009-07-27 17:53 ` Bug fix for eshell-remote-command in lisp/eshell/esh-ext.el Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b97198a0907262117x3440464dv1c513b18f5cfa75@mail.gmail.com \
    --to=lackita@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.