From: Paul Eggert <eggert@cs.ucla.edu>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Scan of Emacs regexp mistakes
Date: Thu, 16 Apr 2020 09:08:47 -0700 [thread overview]
Message-ID: <1b6dd79d-837a-decc-deae-97bf9bc9c460@cs.ucla.edu> (raw)
In-Reply-To: <CC379A11-526C-4216-BD61-429B72FC23DA@acm.org>
On 4/16/20 3:37 AM, Mattias Engdegård wrote:
> The remaining regexp glitches found by the latest sweep were fixed by the attached patch (now on master), except tramp-adb-prompt:
Thanks. One little question:
> - (while (re-search-forward "\\([ \t]*\n[ \t]*\\)+" nil t)
> + (while (re-search-forward "[ \t]*\\(?:\n[ \t]*\\)+" nil t)
> (replace-match " "))
Wouldn't it be better to use "[ \t]*\n[ \t\n]*"?
next prev parent reply other threads:[~2020-04-16 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 12:30 Scan of Emacs regexp mistakes Mattias Engdegård
2020-04-14 10:52 ` Mattias Engdegård
2020-04-14 11:15 ` Andreas Schwab
2020-04-16 10:15 ` Mattias Engdegård
2020-04-14 15:47 ` Drew Adams
2020-04-15 18:19 ` Paul Eggert
2020-04-16 10:29 ` Mattias Engdegård
2020-04-16 10:37 ` Mattias Engdegård
2020-04-16 16:08 ` Paul Eggert [this message]
2020-04-16 18:01 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b6dd79d-837a-decc-deae-97bf9bc9c460@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.